From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Merlijn Wajer <merlijn@wizzup.org>
Subject: [PATCH 1/3] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
Date: Tue, 17 Sep 2019 14:34:59 -0700 [thread overview]
Message-ID: <20190917213501.16907-2-tony@atomide.com> (raw)
In-Reply-To: <20190917213501.16907-1-tony@atomide.com>
From: Pavel Machek <pavel@ucw.cz>
There have been some cases of droid4 battery bulging that seem to
be related to being left connected to the charger for several weeks.
It is suspected that the 4.35V charge voltage configured for the battery
is too much in the long run, so lets limit the charge voltage to 4.2V.
Note that we are using the same register values as the Android distros
on droid4, so it is suspected that the same problem also exists in
Android.
Fixes: 3ae5f06681fc ("power: supply: cpcap-charger: Fix charge voltage configuration")
Reported-by: Merlijn Wajer <merlijn@wizzup.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
[tony@atomide.com: added description of the problem and fixes tag]
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/power/supply/cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -457,7 +457,7 @@ static void cpcap_usb_detect(struct work_struct *work)
max_current = CPCAP_REG_CRM_ICHRG_0A532;
error = cpcap_charger_set_state(ddata,
- CPCAP_REG_CRM_VCHRG_4V35,
+ CPCAP_REG_CRM_VCHRG_4V20,
max_current, 0);
if (error)
goto out_err;
--
2.23.0
next prev parent reply other threads:[~2019-09-17 21:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 21:34 [PATCH 0/3] cpcap charger and battery fixes Tony Lindgren
2019-09-17 21:34 ` Tony Lindgren [this message]
2019-09-19 9:05 ` [PATCH 1/3] power: supply: cpcap-charger: Limit voltage to 4.2V for battery Pavel Machek
2019-09-20 14:03 ` Tony Lindgren
2019-09-17 21:35 ` [PATCH 2/3] power: supply: cpcap-battery: Check voltage before orderly_poweroff Tony Lindgren
2019-09-19 9:14 ` Pavel Machek
2019-09-20 14:12 ` Tony Lindgren
2019-09-22 18:00 ` Tony Lindgren
2019-09-17 21:35 ` [PATCH 3/3] power: supply: cpcap-charger: Improve battery detection Tony Lindgren
2019-09-19 9:19 ` Pavel Machek
2019-09-20 14:18 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917213501.16907-2-tony@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).