From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FAEBC4360C for ; Sun, 13 Oct 2019 10:55:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECDA121882 for ; Sun, 13 Oct 2019 10:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728821AbfJMKz3 (ORCPT ); Sun, 13 Oct 2019 06:55:29 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40455 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728620AbfJMKz3 (ORCPT ); Sun, 13 Oct 2019 06:55:29 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 1B5AD80249; Sun, 13 Oct 2019 12:55:10 +0200 (CEST) Date: Sun, 13 Oct 2019 12:55:05 +0200 From: Pavel Machek To: Tony Lindgren Cc: Sebastian Reichel , linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, Merlijn Wajer Subject: Re: [PATCH 1/5] power: supply: cpcap-battery: Move coulomb counter units per lsb to ddata Message-ID: <20191013105505.GA26237@amd> References: <20191009210621.10522-1-tony@atomide.com> <20191009210621.10522-2-tony@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20191009210621.10522-2-tony@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --KsGdsel6WgEHnImy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-10-09 14:06:17, Tony Lindgren wrote: > We can simplify cpcap_battery_cc_raw_div() a bit by moving the units per > lsb to ddata. >=20 > Cc: Merlijn Wajer > Cc: Pavel Machek > Signed-off-by: Tony Lindgren > --- > drivers/power/supply/cpcap-battery.c | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/= cpcap-battery.c > --- a/drivers/power/supply/cpcap-battery.c > +++ b/drivers/power/supply/cpcap-battery.c > @@ -111,6 +111,7 @@ struct cpcap_battery_ddata { > struct power_supply *psy; > struct cpcap_battery_config config; > struct cpcap_battery_state_data state[CPCAP_BATTERY_STATE_NR]; > + u32 cc_lsb; /* =CE=BCAms per LSB */ micro-Ampere-seconds? Should be uAs? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --KsGdsel6WgEHnImy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl2jAokACgkQMOfwapXb+vLHvgCcDH3Jzo7DRlXg7WHfpaycOW4L Td8AoL6fJ3hD4VcZIRybDHn+nLWhnwsD =eo6j -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--