From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Merlijn Wajer <merlijn@wizzup.org>
Subject: Re: [PATCH] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
Date: Tue, 15 Oct 2019 10:22:23 -0700 [thread overview]
Message-ID: <20191015172223.GZ5610@atomide.com> (raw)
In-Reply-To: <20191013112714.GA5653@amd>
* Pavel Machek <pavel@ucw.cz> [191013 11:27]:
> Hi!
>
> > There have been some cases of droid4 battery bulging that seem to be
> > related to being left connected to the charger for several weeks.
> >
> > It is suspected that the 4.35V charge voltage configured for the battery
> > is too much in the long run, so lets limit the charge voltage to 4.2V.
> > It could also be that the batteries are just getting old.
> >
> > We don't really want to just change the charge voltage to 4.2V as Android
> > may have charged the battery to 3.51.V as pointed out by Pavel
> > Machek.
>
> Now I'm confused. What is 3.51V? Is it typo for 4.35V?
>
> > + /*
> > + * If battery voltage is higher than charge voltage, it may have been
> > + * charged to 3.51V by Android. Try again in 10 minutes.
> > + */
>
> Ok, so maybe it is not a typo. I'm confused.
Hmm a long mistake.. No idea what I was thinking with 3.51..
Yeah both should be 4.35V.
> Note that I'd prefer not to see this in -stable.
OK. In that case I'll send a new version with the typos
fixed against v5.4-rc cycle instead of v5.3.
Regards,
Tony
prev parent reply other threads:[~2019-10-15 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 20:33 [PATCH] power: supply: cpcap-charger: Limit voltage to 4.2V for battery Tony Lindgren
2019-10-09 20:56 ` Tony Lindgren
2019-10-13 11:27 ` Pavel Machek
2019-10-15 17:22 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015172223.GZ5610@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).