From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Merlijn Wajer <merlijn@wizzup.org>
Subject: Re: [PATCHv2] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
Date: Mon, 21 Oct 2019 07:32:23 -0700 [thread overview]
Message-ID: <20191021143223.GU5610@atomide.com> (raw)
In-Reply-To: <20191020203516.sp2vafrvb2pi3hp6@earth.universe>
* Sebastian Reichel <sre@kernel.org> [191020 20:35]:
> Hi Tony,
>
> On Wed, Oct 16, 2019 at 03:18:17PM -0700, Tony Lindgren wrote:
> > There have been some cases of droid4 battery bulging that seem to be
> > related to being left connected to the charger for several weeks.
> >
> > It is suspected that the 4.35V charge voltage configured for the battery
> > is too much in the long run, so lets limit the charge voltage to 4.2V.
> > It could also be that the batteries are just getting old.
> >
> > We don't really want to just change the charge voltage to 4.2V as Android
> > may have charged the battery to 4.35V as pointed out by Pavel Machek.
> >
> > To add checks for battery voltage, the driver needs to understand the
> > voltage it's charging at, and also needs to better understand it's
> > charger state. Right now it only understands connect and disconnect,
> > while now we need to know also a connected state but not charging.
> >
> > So let's add better charger state handling with help of chrgcurr2 interrupt
> > for detecting charge full and retry, and add a check for battery voltage
> > before we start charging. And then we finally can lower the charge voltage
> > to 4.2V.
> >
> > Note that we've been using the same register values as the Android distros
> > on droid4, so it is suspected that the same problem also exists in Android.
> >
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Reported-by: Merlijn Wajer <merlijn@wizzup.org>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >
> > If this looks OK, I would appreciate an immutable branch against v5.4-rc1
> > with just this patch in it for merge conflicts with v5.5 dts changes.
>
> Thanks, I queued this to power-supply's for-next branch using the following
> signed immutable branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git/tag/?h=psy-cpcap-charge-volt-limit-signed
Thanks and sorry about that sparse issue it caused.
Regards,
Tony
prev parent reply other threads:[~2019-10-21 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 22:18 [PATCHv2] power: supply: cpcap-charger: Limit voltage to 4.2V for battery Tony Lindgren
2019-10-20 20:35 ` Sebastian Reichel
2019-10-21 14:32 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021143223.GU5610@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).