From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7DCCA9EB9 for ; Wed, 23 Oct 2019 10:43:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D472C20663 for ; Wed, 23 Oct 2019 10:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571827392; bh=w17ansr82Cw8bMrH42KGu0yry/M/xvT4mqS/2dVIBBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mdq+n40Dw4XN+t3CbodJU3lpeEZTAJVrojWtDnC+PmGOl69TRYn363fOhG/yxB+Nw 5Mk55yltS80DnhPHAVZSOK2GHVVzteXNJGdk5i2ySpKgZlxn8z+z0euYq32uESVju3 LnqX1zjXM+b7YRCbhL9Nnmk3ui2pM9t90MSxHNu0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390935AbfJWKnM (ORCPT ); Wed, 23 Oct 2019 06:43:12 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:49322 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390566AbfJWKnM (ORCPT ); Wed, 23 Oct 2019 06:43:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=o8+aRiWYArgOfcIQUpcz0HRWYDcLBPfXp8bzXS/M6uk=; b=osCh/jbEew5Dyc2YthYufYOzT /wWvYeSc75A8nWZCJhQPtPZQJIPzRLmVMjAZHWDrgPwEE/cD+/tXhLi+RnPHgD+OxlAHWnpdBLkTV GlWNDNNzdGUT/gMTgUuVag18SmkkVxCDkpkaaAQASWnWKQnpLoDjBpCmbLBxBwdkDyz48=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iNE6b-0000J4-QS; Wed, 23 Oct 2019 10:43:05 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 0557E2743259; Wed, 23 Oct 2019 11:43:04 +0100 (BST) Date: Wed, 23 Oct 2019 11:43:04 +0100 From: Mark Brown To: Viresh Kumar Cc: Nathan Chancellor , Kukjin Kim , Krzysztof Kozlowski , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init Message-ID: <20191023104304.GA5723@sirena.co.uk> References: <20191023000906.14374-1-natechancellor@gmail.com> <20191023032302.tu5nkvulo2yoctgr@vireshk-i7> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9amGYk9869ThD9tj" Content-Disposition: inline In-Reply-To: <20191023032302.tu5nkvulo2yoctgr@vireshk-i7> X-Cookie: MMM-MM!! So THIS is BIO-NEBULATION! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --9amGYk9869ThD9tj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 23, 2019 at 08:53:02AM +0530, Viresh Kumar wrote: > On 22-10-19, 17:09, Nathan Chancellor wrote: > > When building with Clang + -Wtautological-pointer-compare: > >=20 > > drivers/cpufreq/s3c64xx-cpufreq.c:152:6: warning: comparison of array > > 's3c64xx_freq_table' equal to a null pointer is always false > > [-Wtautological-pointer-compare] > > if (s3c64xx_freq_table =3D=3D NULL) { > > ^~~~~~~~~~~~~~~~~~ ~~~~ > > 1 warning generated. > >=20 > > The definition of s3c64xx_freq_table is surrounded by an ifdef > > directive for CONFIG_CPU_S3C6410, which is always true for this driver > > because it depends on it in drivers/cpufreq/Kconfig.arm (and if it > > weren't, there would be a build error because s3c64xx_freq_table would > > not be a defined symbol). > +broonie, who wrote this patch to see his views on why he kept it like > this. The driver should also have supported s3c6400 as well. --9amGYk9869ThD9tj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2wLrMACgkQJNaLcl1U h9B2ZAf/eQxJSi8vjkh2szC5fpPoxL3PqhhtoNyHk9pyamhKksLnfq8Wfc5cXoYf m805fFfs10op9oNpI//wwBy+WtmSWx7wFDZx+by2GeKvzPfCqjdXBvUziAtQhq/q pU4RI10nDISz7KV5+MogDYKIqS86tiaCpprrXQI9B524i1u1TCIiaqoW9EC6eho5 104of9kneV1wM3wKRtz1W9HkOlV+Dnm1rDRWldGriYbd+HAJNhxGe+LNiLubnATf N3ntYDNTJmhuwc4KWuzOTHQE+5RXi2VBkk599ZoLoNSZhd6M5a4UU896+XYBjvEN NBjAKyjIVg55uIINznEJ2YtoD+u6qg== =wd9j -----END PGP SIGNATURE----- --9amGYk9869ThD9tj--