From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCEBCCA9EB6 for ; Wed, 23 Oct 2019 16:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C5E321906 for ; Wed, 23 Oct 2019 16:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571849973; bh=XrIyTUIIcwGweoXzbiGvqpSOVSltHgzWrBHeN+yMKhA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mhNqvq5lE/SZuLduRehbI2CCTktzIk6UyrujozUStyFGdREWYEr0n6qLghVcxsKCb 1BF+da3uTB/MnoHK08rKTZVjJhENHhjEG/N0ICT7U3TndsK+BwgncyX8MVDt/h459I 1NvtQDxldnRaD3jtvrjjrKsBWQnya8HHM9LNDai0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726817AbfJWQ7a (ORCPT ); Wed, 23 Oct 2019 12:59:30 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:60776 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbfJWQ73 (ORCPT ); Wed, 23 Oct 2019 12:59:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XrIyTUIIcwGweoXzbiGvqpSOVSltHgzWrBHeN+yMKhA=; b=luoGGER/eGCXKNWHKBECwxZ9x sLCfmNfX4bnSYny15P6DcWr3vzki1ED12Zzs26AainIOjMYSGefPYltHf2uBBfJJzVcOV+gTYjaVQ 4ybUzVgt6iWL9sNjMtyTB93lLR3o6t9ffzuOhla/Yu9gsa8LwoPh2pfc7v6I/psgmtLN8=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iNJym-0000zH-4P; Wed, 23 Oct 2019 16:59:24 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 50EF62743021; Wed, 23 Oct 2019 17:59:23 +0100 (BST) Date: Wed, 23 Oct 2019 17:59:23 +0100 From: Mark Brown To: Nathan Chancellor Cc: Viresh Kumar , Kukjin Kim , Krzysztof Kozlowski , "Rafael J. Wysocki" , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init Message-ID: <20191023165923.GL5723@sirena.co.uk> References: <20191023000906.14374-1-natechancellor@gmail.com> <20191023032302.tu5nkvulo2yoctgr@vireshk-i7> <20191023104304.GA5723@sirena.co.uk> <20191023162628.GA10997@ubuntu-m2-xlarge-x86> <20191023163656.GH5723@sirena.co.uk> <20191023165417.GA15082@ubuntu-m2-xlarge-x86> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AQNmCumFClRcGgHG" Content-Disposition: inline In-Reply-To: <20191023165417.GA15082@ubuntu-m2-xlarge-x86> X-Cookie: MMM-MM!! So THIS is BIO-NEBULATION! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --AQNmCumFClRcGgHG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also have supported s3c6400 as well. > > > Kconfig says otherwise, unless I am missing something. > > Note the XX in the config option. > But what about the depends and the help text? Viresh asked why the driver was written with s3c6410 support optional. I explained that the reason that it was written this way was to accomodate s3c6400 support. --AQNmCumFClRcGgHG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl2whuoACgkQJNaLcl1U h9D5XQf8DtCAVE+KWRLKQff+e0eoyrmuOH64fFlBCM0iJFytXmKaO6yq/o7FQjcx 9CLRRHMdyzXLnTiVGkmkhsVGuAOJPCM+tTjYr/fHoq83Y3cKVSpWnOre95Z52OBa qkawCaJ6i1XrXY0hznOXDb48gQuKG7kecSLaKxGvskoYpI6csEoqeTU/jUKTSMqr GGa5Kdcp4LNd77ZbOWg4TRzUVj9BdcU59SFkOSPB+eA9O/Lers0oGENcu59MrxXF wgJnuQnwnJIv7liRZDk0/z6lSLWqIq32C/nm+AKUrQrD3obXhzvyZnigHpn/hwfV tEmawktj1/+nJxfhTt1gh0vRlbhiyw== =wsTD -----END PGP SIGNATURE----- --AQNmCumFClRcGgHG--