From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC1B2CA9EC3 for ; Tue, 29 Oct 2019 09:44:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8E18208E3 for ; Tue, 29 Oct 2019 09:44:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="phmGA+kR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726689AbfJ2Jow (ORCPT ); Tue, 29 Oct 2019 05:44:52 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:38341 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727504AbfJ2Jow (ORCPT ); Tue, 29 Oct 2019 05:44:52 -0400 Received: by mail-lj1-f193.google.com with SMTP id q78so14518308lje.5 for ; Tue, 29 Oct 2019 02:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DzMq2MqRIWlLfHa8TfPlxgw8jl1ciOvyOzVA0iX+08k=; b=phmGA+kRmcr1rDy1VHR45DZxb+M1HKEiHEmC0BzjVcfGUpv6FwpW/XM/pjHBIVfWBw TmxlfnkQu4DTAwMyNV2HF/nuVH0K0Q3q2Mho6HDvG1qmIFY+NMBKEwwPD0OkKOovGdAX EAwliFdpsTe61O2mUjddNrq/Fnvq4DzDK3mCwVVExcXWuST8YZNxYjGzFFijShyif2o3 pZyLrc5jh6XMNgvAC4ogAXJYAr/T05p/6grgPAtjWW16hfvVNWd8dQFIHbLraudFOOHH uZh13GIpChkfCfL8ff8YaDK3sV1iqMGhIf6r8ge+HBvCU7bh6hMeMUPcPOK+ZRpfcF6y PetA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=DzMq2MqRIWlLfHa8TfPlxgw8jl1ciOvyOzVA0iX+08k=; b=OLTRNectK9huonahR4q8gJpZ6Gz1FH+6Mvrm7RsMICEvmgEszKJHDGKkKqcD8F3zT0 RZM2f+5Arkuwa0KGn2Gow9eHitlJ1yvrvNSLw3U6m6kG6LuZae73+1UlAZVYYUzZax/+ rATTP2/Eh1hxbpWfc3EEWMM7N2UGgwcWFw2vC9EmM6wKWUdU3k2UH3DtwyrPaYrt0nDP nJaypCUN7C6dyWvOemKclP9y4R2mt11hQn1jThZbQDXZGXAMFxG8WfCOkdROBQSEcpup AP8LBSHE5PWugg9oNh9WkRZvvU9/C3HHZc/qLYAEJKa8wTPLT1r5I0O+2avNu5VhPlT9 0MWg== X-Gm-Message-State: APjAAAX7vL0aUMYxdkNkZY5oYk82VF2IDVx3HNgHtYcXya9/wWaohCDr Li/mCV1DNEBWebS1d1BFN8wkhw== X-Google-Smtp-Source: APXvYqy707N4wE+0EQKU22eJJCF5bsPjX97liCtU5EbHVWxOYT/YbdrWSzUn+egOshgMhogTm7UzyQ== X-Received: by 2002:a2e:8652:: with SMTP id i18mr1944129ljj.86.1572342287032; Tue, 29 Oct 2019 02:44:47 -0700 (PDT) Received: from centauri (ua-84-219-138-247.bbcust.telenor.se. [84.219.138.247]) by smtp.gmail.com with ESMTPSA id e8sm10248942ljf.1.2019.10.29.02.44.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 02:44:46 -0700 (PDT) Date: Tue, 29 Oct 2019 10:44:44 +0100 From: Niklas Cassel To: Sudeep Holla Cc: Ulf Hansson , "Rafael J . Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , Mark Rutland , Lina Iyer , Linux PM , Rob Herring , Vincent Guittot , Stephen Boyd , Bjorn Andersson , Kevin Hilman , Linux ARM , linux-arm-msm Subject: Re: [PATCH 10/13] cpuidle: psci: Add a helper to attach a CPU to its PM domain Message-ID: <20191029094444.GA12635@centauri> References: <20191010113937.15962-1-ulf.hansson@linaro.org> <20191010113937.15962-11-ulf.hansson@linaro.org> <20191024163117.GB22036@bogus> <20191027023023.GC18111@e107533-lin.cambridge.arm.com> <20191028074905.GA27884@e107533-lin.cambridge.arm.com> <20191029053414.GA4481@e107533-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029053414.GA4481@e107533-lin.cambridge.arm.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, Oct 29, 2019 at 01:34:24PM +0800, Sudeep Holla wrote: > On Mon, Oct 28, 2019 at 10:45:22AM +0100, Ulf Hansson wrote: > > + Niklas > > > > On Mon, 28 Oct 2019 at 08:49, Sudeep Holla wrote: > > > > > > On Mon, Oct 28, 2019 at 08:35:55AM +0100, Ulf Hansson wrote: > > > > On Sun, 27 Oct 2019 at 03:30, Sudeep Holla wrote: > > > > > > > > > > On Thu, Oct 24, 2019 at 06:47:43PM +0200, Ulf Hansson wrote: > > > > > > On Thu, 24 Oct 2019 at 18:31, Sudeep Holla wrote: > > > > > > > > > > > > > > On Thu, Oct 10, 2019 at 01:39:34PM +0200, Ulf Hansson wrote: > > > > > > > > Introduce a PSCI DT helper function, psci_dt_attach_cpu(), which takes a > > > > > > > > CPU number as an in-parameter and tries to attach the CPU's struct device > > > > > > > > to its corresponding PM domain. > > > > > > > > > > > > > > > > Let's makes use of dev_pm_domain_attach_by_name(), as it allows us to > > > > > > > > specify "psci" as the "name" of the PM domain to attach to. Additionally, > > > > > > > > let's also prepare the attached device to be power managed via runtime PM. > > > > > > > > > > > > > > > > Signed-off-by: Ulf Hansson > > > > > > > > --- > > > > > > > > drivers/cpuidle/cpuidle-psci-domain.c | 21 +++++++++++++++++++++ > > > > > > > > drivers/cpuidle/cpuidle-psci.h | 6 ++++++ > > > > > > > > 2 files changed, 27 insertions(+) > > > > > > > > > > > > > > > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c > > > > > > > > index 3f5143ccc3e0..7429fd7626a1 100644 > > > > > > > > --- a/drivers/cpuidle/cpuidle-psci-domain.c > > > > > > > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c > > > > > > > > @@ -9,9 +9,11 @@ > > > > > > > > > > > > > > > > #define pr_fmt(fmt) "CPUidle PSCI: " fmt > > > > > > > > > > > > > > > > +#include > > > > > > > > #include > > > > > > > > #include > > > > > > > > #include > > > > > > > > +#include > > > > > > > > #include > > > > > > > > #include > > > > > > > > #include > > > > > > > > @@ -279,3 +281,22 @@ static int __init psci_idle_init_domains(void) > > > > > > > > return ret; > > > > > > > > } > > > > > > > > subsys_initcall(psci_idle_init_domains); > > > > > > > > + > > > > > > > > +struct device *psci_dt_attach_cpu(int cpu) > > > > > > > > +{ > > > > > > > > + struct device *dev; > > > > > > > > + > > > > > > > > + /* Currently limit the hierarchical topology to be used in OSI mode. */ > > > > > > > > + if (!psci_has_osi_support()) > > > > > > > > + return NULL; > > > > > > > > + > > > > > > > > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci"); > > > > > > > > > > > > > > This clarifies the need for the fixed name. But why not just go by index 0 > > > > > > > as the consumer of these psci power-domains will have only one power domain > > > > > > > entry. Why do we need this name compulsory ? > > > > > > > > > > > > The idea is to be future proof. If I recall correctly, the CPU node on > > > > > > some QCOM SoCs may also have "CPR" PM domain specified, thus > > > > > > "multiple" power-domains could be specified. > > > > > > > > > > > > > > > > I am sure we don't want to mx-n-match any power domain provider with > > > > > psci. And also I expect in these above mentioned cases, there won't be any > > > > > psci power domains. > > > > > > > > > > > In any case, using "psci" doesn't really hurt, right? > > > > > > > > > > > > > > > > Doesn't but I don't see need for one as only one should exist, as mentioned > > > > > above we don't want mix-n-match with psci ever. > > > > > > > > Not sure I get your point, sorry. > > > > > > > > The CPU could very well be attached to more than one power-domain. Of > > > > course not multiple "PSCI power-domains". One could be an PSCI power > > > > domain and another one could be the QCOM CPR (Core power reduction) > > > > power domain. > > > > > > > > > > And who controls QCOM CPR ? If it's OSPM, this model is broken. > > > I mean OSPM can vote, but the control *has* to be in PSCI firmware to > > > change any CPU power state. > > > > > > If it's firmware controlled, then there's no need to explicitly specify > > > both to OSPM. > > > > This is about OPP and CPUFreq, so it has nothing to do with PSCI. > > > > > > > > > Have a look at these binding, there are already upstream, perhaps that > > > > clarifies this? > > > > Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt > > > > > > > > > > OK, I will have a look. > > > > Great. > > > > I have looped in Niklas Casell, he should be able to answer any more > > detailed questions in regards to QCOM CPR, if that is needed. > > > > So had a look at the DT bindings and standalone it looks fine. > But when it's mixed like the way you describe: yikes! > > Why does a power(oh wait it's actually performance domain!) is combined > with a device whose actual power is controlled by only by PSCI/firmware > is associated along with another power(again actally performance) > domain. > > This whole representation of performance domain as power domain in the > bindings is a *mess*. If Linux kernel chose to implement it as part > of genpd, that's fine. But we should have had a separate binding for > that. > > > In any case, we are discussing whether we should require a > > power-domain-names set to "psci" for the CPU node - and I don't see > > how that could hurt. Right? > > > > Honestly I don't like this, but we don't have any choice I think. > So yes, but you need to update the binding. Hope new platform move > all these performance domain control part into firmware and have single > control from kernel unlike the present generation which OPP through > clock or cpufreq and the voltage/performance comtrol via genpd. FWIW, in newer generation Qualcomm SoCs like SDM845, the voltage/performance control is done in firmware, by the OSM (drivers/cpufreq/qcom-cpufreq-hw.c). Kind regards, Niklas