[PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver

linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver
       [not found] <CGME20191028152057eucas1p1d6b4252e9ce3f15c0d81e6941a62d2be@eucas1p1.samsung.com>
@ 2019-10-28 15:20 ` Sylwester Nawrocki
  2019-10-28 15:20   ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Sylwester Nawrocki @ 2019-10-28 15:20 UTC (permalink / raw)
  To: krzk, robh+dt
  Cc: devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski, Sylwester Nawrocki

As we dropped the requirement of "syscon" compatible in the chipid
nodes rework code acquiring the regmap to use device_node_to_regmap()
rather than syscon_node_to_regmap().

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 drivers/soc/samsung/exynos-chipid.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exynos-chipid.c
index 25562dd0b206..b89c26a71c6e 100644
--- a/drivers/soc/samsung/exynos-chipid.c
+++ b/drivers/soc/samsung/exynos-chipid.c
@@ -50,12 +50,20 @@ static int __init exynos_chipid_early_init(void)
 	struct soc_device_attribute *soc_dev_attr;
 	struct soc_device *soc_dev;
 	struct device_node *root;
+	struct device_node *syscon;
 	struct regmap *regmap;
 	u32 product_id;
 	u32 revision;
 	int ret;
 
-	regmap = syscon_regmap_lookup_by_compatible("samsung,exynos4210-chipid");
+	syscon = of_find_compatible_node(NULL, NULL,
+					 "samsung,exynos4210-chipid");
+	if (!syscon)
+		return ENODEV;
+
+	regmap = device_node_to_regmap(syscon);
+	of_node_put(syscon);
+
 	if (IS_ERR(regmap))
 		return PTR_ERR(regmap);
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5
  2019-10-28 15:20 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Sylwester Nawrocki
@ 2019-10-28 15:20   ` Sylwester Nawrocki
  2019-12-11 18:20     ` Krzysztof Kozlowski
  2019-10-28 15:20   ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
  2019-10-28 17:35   ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Krzysztof Kozlowski
  2 siblings, 1 reply; 7+ messages in thread
From: Sylwester Nawrocki @ 2019-10-28 15:20 UTC (permalink / raw)
  To: krzk, robh+dt
  Cc: devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski, Sylwester Nawrocki

The "syscon" compatible string was introduced in commit ("cdcce1ee977b
ARM: dts: exynos: Add "syscon" compatible string to chipid node on Exynos5")
to allow sharing of the CHIPID IO region between multiple drivers.
However, such sharing can be also done without an additional compatible
so remove the syscon entry.

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 arch/arm/boot/dts/exynos5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos5.dtsi b/arch/arm/boot/dts/exynos5.dtsi
index 4801ca759feb..22eb951c614c 100644
--- a/arch/arm/boot/dts/exynos5.dtsi
+++ b/arch/arm/boot/dts/exynos5.dtsi
@@ -36,7 +36,7 @@
 		ranges;
 
 		chipid: chipid@10000000 {
-			compatible = "samsung,exynos4210-chipid", "syscon";
+			compatible = "samsung,exynos4210-chipid";
 			reg = <0x10000000 0x100>;
 		};
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5
  2019-10-28 15:20   ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
@ 2019-12-11 18:20     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-11 18:20 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: robh+dt, devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski

On Mon, Oct 28, 2019 at 04:20:49PM +0100, Sylwester Nawrocki wrote:
> The "syscon" compatible string was introduced in commit ("cdcce1ee977b
> ARM: dts: exynos: Add "syscon" compatible string to chipid node on Exynos5")
> to allow sharing of the CHIPID IO region between multiple drivers.
> However, such sharing can be also done without an additional compatible
> so remove the syscon entry.
> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5.dtsi | 2 +-

Thanks, applied.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding
  2019-10-28 15:20 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Sylwester Nawrocki
  2019-10-28 15:20   ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
@ 2019-10-28 15:20   ` Sylwester Nawrocki
  2019-10-28 15:47     ` Krzysztof Kozlowski
  2019-11-06  3:28     ` Rob Herring
  2019-10-28 17:35   ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Krzysztof Kozlowski
  2 siblings, 2 replies; 7+ messages in thread
From: Sylwester Nawrocki @ 2019-10-28 15:20 UTC (permalink / raw)
  To: krzk, robh+dt
  Cc: devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski, Sylwester Nawrocki

The "syscon" compatible string was introduced mainly to allow sharing
of the CHIPID IO region between multiple drivers. However, such sharing
can be also done without an additional compatible so remove "syscon".

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
 .../devicetree/bindings/arm/samsung/exynos-chipid.yaml         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
index 53c29d567789..afcd70803c12 100644
--- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
@@ -13,7 +13,6 @@ properties:
   compatible:
     items:
       - const: samsung,exynos4210-chipid
-      - const: syscon
 
   reg:
     maxItems: 1
@@ -34,7 +33,7 @@ required:
 examples:
   - |
     chipid@10000000 {
-        compatible = "samsung,exynos4210-chipid", "syscon";
+        compatible = "samsung,exynos4210-chipid";
         reg = <0x10000000 0x100>;
         samsung,asv-bin = <2>;
     };
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding
  2019-10-28 15:20   ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
@ 2019-10-28 15:47     ` Krzysztof Kozlowski
  2019-11-06  3:28     ` Rob Herring
  1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-28 15:47 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: robh+dt, devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski

On Mon, Oct 28, 2019 at 04:20:50PM +0100, Sylwester Nawrocki wrote:
> The "syscon" compatible string was introduced mainly to allow sharing
> of the CHIPID IO region between multiple drivers. However, such sharing
> can be also done without an additional compatible so remove "syscon".

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  .../devicetree/bindings/arm/samsung/exynos-chipid.yaml         | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> index 53c29d567789..afcd70803c12 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-chipid.yaml
> @@ -13,7 +13,6 @@ properties:
>    compatible:
>      items:
>        - const: samsung,exynos4210-chipid
> -      - const: syscon
>  
>    reg:
>      maxItems: 1
> @@ -34,7 +33,7 @@ required:
>  examples:
>    - |
>      chipid@10000000 {
> -        compatible = "samsung,exynos4210-chipid", "syscon";
> +        compatible = "samsung,exynos4210-chipid";
>          reg = <0x10000000 0x100>;
>          samsung,asv-bin = <2>;
>      };
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from  CHIPID binding
  2019-10-28 15:20   ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
  2019-10-28 15:47     ` Krzysztof Kozlowski
@ 2019-11-06  3:28     ` Rob Herring
  1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2019-11-06  3:28 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: krzk, robh+dt, devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski, Sylwester Nawrocki

On Mon, 28 Oct 2019 16:20:50 +0100, Sylwester Nawrocki wrote:
> The "syscon" compatible string was introduced mainly to allow sharing
> of the CHIPID IO region between multiple drivers. However, such sharing
> can be also done without an additional compatible so remove "syscon".
> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  .../devicetree/bindings/arm/samsung/exynos-chipid.yaml         | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 

Applied, thanks.

Rob

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver
  2019-10-28 15:20 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Sylwester Nawrocki
  2019-10-28 15:20   ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
  2019-10-28 15:20   ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
@ 2019-10-28 17:35   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2019-10-28 17:35 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: robh+dt, devicetree, vireshk, linux-pm, linux-arm-kernel,
	linux-samsung-soc, b.zolnierkie, m.szyprowski

On Mon, Oct 28, 2019 at 04:20:48PM +0100, Sylwester Nawrocki wrote:
> As we dropped the requirement of "syscon" compatible in the chipid
> nodes rework code acquiring the regmap to use device_node_to_regmap()
> rather than syscon_node_to_regmap().
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  drivers/soc/samsung/exynos-chipid.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Thanks, applied.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-12-11 18:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20191028152057eucas1p1d6b4252e9ce3f15c0d81e6941a62d2be@eucas1p1.samsung.com>
2019-10-28 15:20 ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Sylwester Nawrocki
2019-10-28 15:20   ` [PATCH 2/3] ARM: dts: exynos: Remove syscon compatible from chipid node on Exynos5 Sylwester Nawrocki
2019-12-11 18:20     ` Krzysztof Kozlowski
2019-10-28 15:20   ` [PATCH 3/3] dt-bindings: arm: samsung: Drop syscon compatible from CHIPID binding Sylwester Nawrocki
2019-10-28 15:47     ` Krzysztof Kozlowski
2019-11-06  3:28     ` Rob Herring
2019-10-28 17:35   ` [PATCH 1/3] soc: samsung: Drop "syscon" compatible requirement from the chipid driver Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).