From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD3EC5DF63 for ; Wed, 6 Nov 2019 21:29:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8299A217F5 for ; Wed, 6 Nov 2019 21:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbfKFV3i (ORCPT ); Wed, 6 Nov 2019 16:29:38 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:56578 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726779AbfKFV3i (ORCPT ); Wed, 6 Nov 2019 16:29:38 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 9B5A81C09B6; Wed, 6 Nov 2019 22:29:36 +0100 (CET) Date: Wed, 6 Nov 2019 22:29:21 +0100 From: Pavel Machek To: Keith Busch Cc: Guenter Roeck , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Akinobu Mita , linux-pm@vger.kernel.org, Chris Healy Subject: Re: [PATCH v2] nvme: Add hardware monitoring support Message-ID: <20191106212921.GA7020@amd> References: <20191029223214.18889-1-linux@roeck-us.net> <20191030005327.GC15332@redsun51.ssa.fujisawa.hgst.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline In-Reply-To: <20191030005327.GC15332@redsun51.ssa.fujisawa.hgst.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > nvme devices report temperature information in the controller informati= on > > (for limits) and in the smart log. Currently, the only means to retrieve > > this information is the nvme command line interface, which requires > > super-user privileges. > >=20 > > At the same time, it would be desirable to use NVME temperature informa= tion > > for thermal control. > >=20 > > This patch adds support to read NVME temperatures from the kernel using= the > > hwmon API and adds temperature zones for NVME drives. The thermal subsy= stem > > can use this information to set thermal policies, and userspace can acc= ess > > it using libsensors and/or the "sensors" command. > >=20 > > Example output from the "sensors" command: > >=20 > > nvme0-pci-0100 > > Adapter: PCI adapter > > Composite: +39.0=B0C (high =3D +85.0=B0C, crit =3D +85.0=B0C) > > Sensor 1: +39.0=B0C > > Sensor 2: +41.0=B0C > >=20 > > Signed-off-by: Guenter Roeck >=20 > This looks fine to me, but I'll wait a few more days to see if there are > any additional comments.. User wants to know temperature of /dev/sda... and we already have an userspace tools knowing about smart, etc... pavel@amd:/data/film$ sudo hddtemp /dev/sda /dev/sda: ST1000LM014-1EJ164: 48=B0C I see we also have sensors framework but it does _not_ handle harddrive temperatures. Does it need some kind of unification? Should NVMe devices expose "SMART" information in the same way other SSDs do? Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3DOzEACgkQMOfwapXb+vIMvACfQ4av1AszPWgW7jbyZuTg6fmz a2EAoIkF7v4EygABLAACFFwF9dxY14dS =o7Jq -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT--