From: Viresh Kumar <viresh.kumar@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, edubezval@gmail.com,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Guillaume La Roque <glaroque@baylibre.com>,
Heiko Stuebner <heiko@sntech.de>,
Javi Merino <javi.merino@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jun Nie <jun.nie@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 08/11] thermal: samsung: Appease the kernel-doc deity
Date: Thu, 7 Nov 2019 07:51:25 +0530 [thread overview]
Message-ID: <20191107022125.wkdsdoolondcxhju@vireshk-i7> (raw)
In-Reply-To: <ef268335454e96e6ee3d13deb1cb89af0d0a3b61.1573046440.git.amit.kucheria@linaro.org>
On 06-11-19, 18:58, Amit Kucheria wrote:
> Fix up the following warning when compiled with make W=1:
>
> linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = '
> linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = '
> linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = '
> linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = '
> linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius'
Incorrect log here.
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fb2c55123a99e..8193b66a3f831 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -138,7 +138,7 @@ enum soc_type {
>
> /**
> * struct exynos_tmu_data : A structure to hold the private data of the TMU
> - driver
> + * driver
> * @id: identifier of the one instance of the TMU controller.
> * @base: base address of the single instance of the TMU controller.
> * @base_second: base address of the common registers of the TMU controller.
> @@ -162,8 +162,11 @@ enum soc_type {
> * 0 < reference_voltage <= 31
> * @regulator: pointer to the TMU regulator structure.
> * @reg_conf: pointer to structure to register with core thermal.
> + * @tzd: pointer to thermal_zone_device structure
> * @ntrip: number of supported trip points.
> * @enabled: current status of TMU device
> + * @tmu_set_trip_temp: SoC specific method to set trip (rising threshold)
> + * @tmu_set_trip_hyst: SoC specific to set hysteresis (falling threshold)
> * @tmu_initialize: SoC specific TMU initialization method
> * @tmu_control: SoC specific TMU control method
> * @tmu_read: SoC specific TMU temperature read method
> --
> 2.17.1
--
viresh
next prev parent reply other threads:[~2019-11-07 2:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 13:28 [PATCH 00/11] thermal: clean up output of make W=1 Amit Kucheria
2019-11-06 13:28 ` [PATCH 01/11] thermal: of-thermal: Appease the kernel-doc deity Amit Kucheria
2019-11-07 2:15 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 02/11] thermal: cpu_cooling: " Amit Kucheria
2019-11-07 2:16 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 03/11] thermal: step_wise: " Amit Kucheria
2019-11-07 2:16 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 04/11] thermal: devfreq_cooling: " Amit Kucheria
2019-11-07 2:17 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 05/11] thermal: max77620: " Amit Kucheria
2019-11-07 2:17 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 06/11] thermal: mediatek: " Amit Kucheria
2019-11-07 2:19 ` Viresh Kumar
2019-11-07 2:20 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 07/11] thermal: rockchip: " Amit Kucheria
2019-11-07 2:20 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 08/11] thermal: samsung: " Amit Kucheria
2019-11-07 2:21 ` Viresh Kumar [this message]
2019-11-06 13:28 ` [PATCH 09/11] thermal: tegra: " Amit Kucheria
2019-11-07 2:22 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 10/11] thermal: amlogic: " Amit Kucheria
2019-11-07 2:22 ` Viresh Kumar
2019-11-06 13:28 ` [PATCH 11/11] thermal: zx2967: " Amit Kucheria
2019-11-07 2:22 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107022125.wkdsdoolondcxhju@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=glaroque@baylibre.com \
--cc=heiko@sntech.de \
--cc=javi.merino@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=jun.nie@linaro.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox