From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C899AFC6196 for ; Fri, 8 Nov 2019 21:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9C364206C3 for ; Fri, 8 Nov 2019 21:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730923AbfKHVDI (ORCPT ); Fri, 8 Nov 2019 16:03:08 -0500 Received: from muru.com ([72.249.23.125]:41224 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730159AbfKHVDI (ORCPT ); Fri, 8 Nov 2019 16:03:08 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 3F87180D4; Fri, 8 Nov 2019 21:03:43 +0000 (UTC) Date: Fri, 8 Nov 2019 13:03:04 -0800 From: Tony Lindgren To: Adam Ford Cc: Linux-OMAP , "H. Nikolaus Schaller" , Adam Ford , Eduardo Valentin , Keerthy , Zhang Rui , Daniel Lezcano , Amit Kucheria , linux-pm@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH] thermal: ti-soc-thermal: Enable addition power management Message-ID: <20191108210304.GQ5610@atomide.com> References: <20191108200501.29864-1-aford173@gmail.com> <20191108204531.GN5610@atomide.com> <20191108205050.GO5610@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Adam Ford [191108 20:58]: > On Fri, Nov 8, 2019 at 2:50 PM Tony Lindgren wrote: > > > > * Tony Lindgren [191108 20:46]: > > > Also, you may want to check if the driver needs to > > > save and restore it's context in the notifier as that > > > might get lost during the off mode depending what > > > domain it's at. > > > > Oh never mind, looks like you already took care of > > saving and restoring the context in the notifier, > > I just missed it. > > Great! > > Is there any testing you can do and think we need on the OMAP4/5+ or > am33xx? I don't have any of that hardware. I can test oswr idle (open switch retention) on droid4 which means save and restore of context is needed like it is for off mode. > I'm readying a patch without the RFC shortly. OK will give it a try and reply when done. Regards, Tony