linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Perret <qperret@google.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
	daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
	viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] thermal: power_allocator: Fix Kconfig warning
Date: Tue, 12 Nov 2019 15:13:19 +0000	[thread overview]
Message-ID: <20191112151319.GA239065@google.com> (raw)
In-Reply-To: <20191112145114.36580-1-yuehaibing@huawei.com>

On Tuesday 12 Nov 2019 at 22:51:14 (+0800), YueHaibing wrote:
> When do randbuiding, we got this:
> 
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
>   Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
>   Selected by [y]:
>   - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>

This will not cause run-time problems, but I guess the warning is
annoying so ...

> Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
>  
> Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")

Daniel: can we rely on this sha1 ? Or is this branch force-pushed ?

> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/thermal/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc..5e9e038 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>  
>  config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
>  	bool "power_allocator"
> +	depends on ENERGY_MODEL
>  	select THERMAL_GOV_POWER_ALLOCATOR
>  	help
>  	  Select this if you want to control temperature based on
> -- 
> 2.7.4

Thanks,
Quentin

  reply	other threads:[~2019-11-12 15:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 14:51 [PATCH -next] thermal: power_allocator: Fix Kconfig warning YueHaibing
2019-11-12 15:13 ` Quentin Perret [this message]
2019-11-12 15:28   ` Quentin Perret
2019-11-13 10:53     ` [PATCH v2 " YueHaibing
2019-12-04 15:49       ` Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112151319.GA239065@google.com \
    --to=qperret@google.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).