From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
sudeep.holla@arm.com, edubezval@gmail.com, agross@kernel.org,
tdas@codeaurora.org, swboyd@chromium.org, ilina@codeaurora.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Amit Kucheria <amit.kucheria@verdurent.com>,
Ben Segall <bsegall@google.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>, Mel Gorman <mgorman@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 6/6] cpufreq: qcom-hw: Move driver initialisation earlier
Date: Tue, 12 Nov 2019 16:30:36 -0800 [thread overview]
Message-ID: <20191113003036.GA3143381@builder> (raw)
In-Reply-To: <3d367762ba72fa1cbd6391dc55d94b3284f6c00c.1571387352.git.amit.kucheria@linaro.org>
On Fri 18 Oct 01:52 PDT 2019, Amit Kucheria wrote:
> Allow qcom-hw driver to initialise right after the cpufreq and thermal
> subsystems are initialised in core_initcall so we get earlier access to
> thermal mitigation.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Taniya Das <tdas@codeaurora.org>
Hi Amit,
Booting linux-next on my db845c (and SDM850 laptop) I can see that the
device probes in /sys/bus/platform/drivers/qcom-cpufreq-hw, but
/sys/devices/system/cpu/cpufreq is empty.
Reverting this change gives me cpufreq back. Can you please have a look
at this?
Regards,
Bjorn
> ---
> drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
> index a9ae2f84a4efc..fc92a8842e252 100644
> --- a/drivers/cpufreq/qcom-cpufreq-hw.c
> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c
> @@ -334,7 +334,7 @@ static int __init qcom_cpufreq_hw_init(void)
> {
> return platform_driver_register(&qcom_cpufreq_hw_driver);
> }
> -device_initcall(qcom_cpufreq_hw_init);
> +postcore_initcall(qcom_cpufreq_hw_init);
>
> static void __exit qcom_cpufreq_hw_exit(void)
> {
> --
> 2.17.1
>
prev parent reply other threads:[~2019-11-13 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 8:51 [PATCH v4 0/6] Initialise thermal framework and cpufreq earlier during boot Amit Kucheria
2019-10-18 8:51 ` [PATCH v4 1/6] thermal: Remove netlink support Amit Kucheria
2019-10-18 8:51 ` [PATCH v4 2/6] thermal: Initialize thermal subsystem earlier Amit Kucheria
2019-10-18 8:52 ` [PATCH v4 3/6] cpufreq: Initialise the governors in core_initcall Amit Kucheria
2019-10-18 10:22 ` Rafael J. Wysocki
2019-10-18 8:52 ` [PATCH v4 4/6] cpufreq: Initialize cpufreq-dt driver earlier Amit Kucheria
2019-10-21 8:08 ` Ingo Molnar
2019-10-21 8:59 ` Amit Kucheria
2019-10-18 8:52 ` [PATCH v4 6/6] cpufreq: qcom-hw: Move driver initialisation earlier Amit Kucheria
2019-10-18 9:51 ` Viresh Kumar
2019-11-13 0:30 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113003036.GA3143381@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=bsegall@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ilina@codeaurora.org \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sudeep.holla@arm.com \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).