From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13240C432C3 for ; Fri, 15 Nov 2019 20:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8852206D9 for ; Fri, 15 Nov 2019 20:13:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KLlt0GWj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726567AbfKOUNk (ORCPT ); Fri, 15 Nov 2019 15:13:40 -0500 Received: from merlin.infradead.org ([205.233.59.134]:35554 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbfKOUNk (ORCPT ); Fri, 15 Nov 2019 15:13:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=U04AK+OppLVeV3O4pLzN/YFK2FxmH5fvNNCh3MF92IY=; b=KLlt0GWj6whouRd+kp6oFHl+D Ej7uCVDEWwpmYgi1CuUy5ZPt4CSESoygcANnBUp+FylIfcx8PPNchrIElja8DG5PgRxvTVxbva91r eXKYgGugBmZsrVp6eYvXJVghy/Al6Zlc+5vATGmz4ksfuLstcAJUN4KPT7X6gKQX3XM7OumtCivB9 jjTOxs1YffJtEKFKN3WoQTSR3DgCKKD1PMXpnOuoivG3gFMtKoZ+bOz0n04eMOKAERlQglZB6/UBZ F5vqDh1JcH1j8bmCDBNyEI+n9Xyv0bz0OA+0bZWU07VL5bkLBDDR3bBrFZUmR5/l7AdkRgBQdqvFE ryAGRW+eg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1iVhxm-00048n-Ot; Fri, 15 Nov 2019 20:13:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id F0A3C3056C8; Fri, 15 Nov 2019 21:11:48 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id ECE222B12EE0A; Fri, 15 Nov 2019 21:12:56 +0100 (CET) Date: Fri, 15 Nov 2019 21:12:56 +0100 From: Peter Zijlstra To: Vincent Guittot Cc: linux-kernel , Ingo Molnar , Dietmar Eggemann , Juri Lelli , Steven Rostedt , Mel Gorman , Doug Smythies , "open list:THERMAL" , Linus Torvalds , Thomas Gleixner , Sargun Dhillon , Tejun Heo , Xie XiuQi , xiezhipeng1@huawei.com, Srinivas Pandruvada Subject: Re: [PATCH v4] sched/freq: move call to cpufreq_update_util Message-ID: <20191115201256.GQ4131@hirez.programming.kicks-ass.net> References: <1573751251-3505-1-git-send-email-vincent.guittot@linaro.org> <20191115132520.GJ4131@hirez.programming.kicks-ass.net> <20191115151220.GO4131@hirez.programming.kicks-ass.net> <20191115174355.GP4131@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Nov 15, 2019 at 07:00:45PM +0100, Vincent Guittot wrote: > On Fri, 15 Nov 2019 at 18:44, Peter Zijlstra wrote: > > Because we don't care about the rt,dl,irq decay anywhere else either. We > > only call cpufreq_update_util() for rq->cfs changes. > > cpufreq_update_util is called for each enqueue/dequeue of rt/dl tasks Oh indeed.. OK, so then I suppose rt,dl,cfs makes some sense. Let me sleep on it.