From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Daniel Drake <drake@endlessm.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
rafael.j.wysocki@intel.com, linux@endlessm.com,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 2/2] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers
Date: Wed, 27 Nov 2019 13:50:55 +0200 [thread overview]
Message-ID: <20191127115055.GB11621@lahna.fi.intel.com> (raw)
In-Reply-To: <20191127053836.31624-2-drake@endlessm.com>
On Wed, Nov 27, 2019 at 01:38:36PM +0800, Daniel Drake wrote:
> On Asus UX434DA (AMD Ryzen7 3700U) and Asus X512DK (AMD Ryzen5 3500U),
> the XHCI controller fails to resume from runtime suspend or s2idle,
> and USB becomes unusable from that point.
>
> xhci_hcd 0000:03:00.4: Refused to change power state, currently in D3
> xhci_hcd 0000:03:00.4: enabling device (0000 -> 0002)
> xhci_hcd 0000:03:00.4: WARN: xHC restore state timeout
> xhci_hcd 0000:03:00.4: PCI post-resume error -110!
> xhci_hcd 0000:03:00.4: HC died; cleaning up
>
> During suspend, a transition to D3cold is attempted, however the affected
> platforms do not seem to cut the power to the PCI device when in this
> state, so the device stays in D3hot.
>
> Upon resume, the D3hot-to-D0 transition is successful only if the D3 delay
> is increased to 20ms. The transition failure does not appear to be
> detectable as a CRS condition. Add a PCI quirk to increase the delay on the
> affected hardware.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=205587
> Link: http://lkml.kernel.org/r/CAD8Lp47Vh69gQjROYG69=waJgL7hs1PwnLonL9+27S_TcRhixA@mail.gmail.com
> Signed-off-by: Daniel Drake <drake@endlessm.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
next prev parent reply other threads:[~2019-11-27 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:38 [PATCH v2 1/2] PCI: add generic quirk function for increasing D3hot delay Daniel Drake
2019-11-27 5:38 ` [PATCH v2 2/2] PCI: increase D3 delay for AMD Ryzen5/7 XHCI controllers Daniel Drake
2019-11-27 11:50 ` Mika Westerberg [this message]
2019-11-27 11:50 ` [PATCH v2 1/2] PCI: add generic quirk function for increasing D3hot delay Mika Westerberg
2019-12-12 9:51 ` Daniel Drake
2019-12-13 21:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127115055.GB11621@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=drake@endlessm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).