From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0DEC3F68F for ; Thu, 19 Dec 2019 14:33:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAB5824679 for ; Thu, 19 Dec 2019 14:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbfLSOdp (ORCPT ); Thu, 19 Dec 2019 09:33:45 -0500 Received: from foss.arm.com ([217.140.110.172]:39460 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbfLSOdp (ORCPT ); Thu, 19 Dec 2019 09:33:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90F9031B; Thu, 19 Dec 2019 06:33:44 -0800 (PST) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 982CF3F6CF; Thu, 19 Dec 2019 06:33:42 -0800 (PST) Date: Thu, 19 Dec 2019 14:33:40 +0000 From: Sudeep Holla To: Ulf Hansson Cc: Lorenzo Pieralisi , Rob Herring , linux-pm@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Mark Rutland , Lina Iyer , Vincent Guittot , Stephen Boyd , Andy Gross , Bjorn Andersson , Kevin Hilman , Sudeep Holla , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v4 12/14] cpuidle: psci: Support CPU hotplug for the hierarchical model Message-ID: <20191219143340.GE20746@bogus> References: <20191211154343.29765-1-ulf.hansson@linaro.org> <20191211154343.29765-13-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211154343.29765-13-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, Dec 11, 2019 at 04:43:41PM +0100, Ulf Hansson wrote: > When the hierarchical CPU topology is used and when a CPU is put offline, > that CPU prevents its PM domain from being powered off, which is because > genpd observes the corresponding attached device as being active from a > runtime PM point of view. Furthermore, any potential master PM domains are > also prevented from being powered off. > > To address this limitation, let's add add a new CPU hotplug state > (CPUHP_AP_CPU_PM_STARTING) and register up/down callbacks for it, which > allows us to deal with runtime PM accordingly. > > Signed-off-by: Ulf Hansson > --- > > Changes in v4: > - Folded in the patch to be part of the series. > - Rebased on top of earlier changes. > > --- > drivers/cpuidle/cpuidle-psci.c | 45 +++++++++++++++++++++++++++++++++- > include/linux/cpuhotplug.h | 1 + > 2 files changed, 45 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c > index 6e7804e697ed..34a89d99bb0f 100644 > --- a/drivers/cpuidle/cpuidle-psci.c > +++ b/drivers/cpuidle/cpuidle-psci.c > @@ -8,6 +8,7 @@ > > #define pr_fmt(fmt) "CPUidle PSCI: " fmt > > +#include > #include > #include > #include > @@ -31,6 +32,7 @@ struct psci_cpuidle_data { > > static DEFINE_PER_CPU_READ_MOSTLY(struct psci_cpuidle_data, psci_cpuidle_data); > static DEFINE_PER_CPU(u32, domain_state); > +static bool psci_cpuidle_use_cpuhp; > [...] > + > +static void psci_idle_init_cpuhp(void) > +{ Can this be made __init along with the boolean psci_cpuidle_use_cpuhp ? With that, Reviewed-by: Sudeep Holla -- Regards, Sudeep