From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0DCCC2D0C2 for ; Thu, 2 Jan 2020 19:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0A8121835 for ; Thu, 2 Jan 2020 19:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H+0nJyd9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728176AbgABTQq (ORCPT ); Thu, 2 Jan 2020 14:16:46 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:41433 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728116AbgABTQq (ORCPT ); Thu, 2 Jan 2020 14:16:46 -0500 Received: by mail-pf1-f196.google.com with SMTP id w62so22460782pfw.8 for ; Thu, 02 Jan 2020 11:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0G0HGF1V+/eZV+R76M5292usDeBEi2ZV+5zg9De534I=; b=H+0nJyd9BP7uZVDk2tPmZAKTlaEy/XwnzS+I7Nwku0zG9asxJwolAtGlAzqxMDR2gl KZWwxOJVEr+COOkwgLFwvMknyUM4TYRwhpEnVD6C7txKSt/dpga6auxVMi59DCgBPwlS u69oUE2GoSdm8pfeAqqTKfGlYtceXi2GUyj31kyTJgJsgClPVau9ZNlYsUC78+j8tS04 ygXnJaKBwMJLr7iwnP6iEGFYPQ6ExCzN9umd9a8UGMSA5rw64UtmDxoZe9MNLpLlWbmW iWbFLx3J86Gds9e5+2YbiBaldMfZvezQdVSB7EGD0dJbw8xnChjpU6iDeQlHKW4nElcl U7zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0G0HGF1V+/eZV+R76M5292usDeBEi2ZV+5zg9De534I=; b=N3PcUdAcvOCXpk8aftbitOL61UAbOe+5sHmSq99RLgSoGbKK2zkG4zM5IQK6tfgggR IRa2RWs1FXY64jX02UTh4+T0+RB8fdiY8rIAKqSC4MkBmsXxK3YNHcax7ufyYsb11ttM RzmJCapM/tWNzrTXJ6zJEAlpDd+CuZicxlpscY2l/dIq+8NHE3+kCcHcAQ/lV3EuaEW2 tR0bv7NXW7AXuFTzojw7UC22rtJbOZ6v/uO/spqm40+A69rEGoPTevHpXYFZkV40xUHW GYkljoxKtRd96WQoDMtYWQN478rsuWYYVaA1XhR7Yd/X6b3FuI2gP/ZzUnXZoMZ0wGfJ 8pHw== X-Gm-Message-State: APjAAAUsfC61WT0TpKhv6yjY0BVkAJi43kWnT3gc5BMrEuZxMIReixUC nsAYFTWraqln5QPco8QGpZTkkQ== X-Google-Smtp-Source: APXvYqyhkEw2BAcCX9dqkNSek/hdLar87nI+t5C7ViEHXKEYX5lKV7SAhYLV/z3tt3h3wsaIWQMmqg== X-Received: by 2002:a63:1106:: with SMTP id g6mr90795614pgl.13.1577992605410; Thu, 02 Jan 2020 11:16:45 -0800 (PST) Received: from minitux (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id a6sm58823755pgg.25.2020.01.02.11.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 11:16:44 -0800 (PST) Date: Thu, 2 Jan 2020 11:16:42 -0800 From: Bjorn Andersson To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross , Amit Kucheria , linux-pm@vger.kernel.org Subject: Re: [PATCH v3 2/9] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Message-ID: <20200102191642.GA988120@minitux> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu 02 Jan 06:54 PST 2020, Amit Kucheria wrote: > All the sensor data is initialised at init time. Lock it down by passing > it to functions as a constant. > Reviewed-by: Bjorn Andersson > Signed-off-by: Amit Kucheria > --- > drivers/thermal/qcom/tsens-8960.c | 2 +- > drivers/thermal/qcom/tsens-common.c | 14 +++++++------- > drivers/thermal/qcom/tsens.h | 6 +++--- > 3 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c > index a383a57cfbbc..2a28a5af209e 100644 > --- a/drivers/thermal/qcom/tsens-8960.c > +++ b/drivers/thermal/qcom/tsens-8960.c > @@ -245,7 +245,7 @@ static inline int code_to_mdegC(u32 adc_code, const struct tsens_sensor *s) > return adc_code * slope + offset; > } > > -static int get_temp_8960(struct tsens_sensor *s, int *temp) > +static int get_temp_8960(const struct tsens_sensor *s, int *temp) > { > int ret; > u32 code, trdy; > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index c8d57ee0a5bb..c2df30a08b9e 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -128,7 +128,7 @@ static inline int code_to_degc(u32 adc_code, const struct tsens_sensor *s) > * Return: Temperature in milliCelsius on success, a negative errno will > * be returned in error cases > */ > -static int tsens_hw_to_mC(struct tsens_sensor *s, int field) > +static int tsens_hw_to_mC(const struct tsens_sensor *s, int field) > { > struct tsens_priv *priv = s->priv; > u32 resolution; > @@ -160,7 +160,7 @@ static int tsens_hw_to_mC(struct tsens_sensor *s, int field) > * > * Return: ADC code or temperature in deciCelsius. > */ > -static int tsens_mC_to_hw(struct tsens_sensor *s, int temp) > +static int tsens_mC_to_hw(const struct tsens_sensor *s, int temp) > { > struct tsens_priv *priv = s->priv; > > @@ -275,7 +275,7 @@ static int tsens_threshold_violated(struct tsens_priv *priv, u32 hw_id, > } > > static int tsens_read_irq_state(struct tsens_priv *priv, u32 hw_id, > - struct tsens_sensor *s, struct tsens_irq_data *d) > + const struct tsens_sensor *s, struct tsens_irq_data *d) > { > int ret; > > @@ -346,10 +346,10 @@ irqreturn_t tsens_irq_thread(int irq, void *data) > > for (i = 0; i < priv->num_sensors; i++) { > bool trigger = false; > - struct tsens_sensor *s = &priv->sensor[i]; > + const struct tsens_sensor *s = &priv->sensor[i]; > u32 hw_id = s->hw_id; > > - if (IS_ERR(priv->sensor[i].tzd)) > + if (IS_ERR(s->tzd)) > continue; > if (!tsens_threshold_violated(priv, hw_id, &d)) > continue; > @@ -457,7 +457,7 @@ void tsens_disable_irq(struct tsens_priv *priv) > regmap_field_write(priv->rf[INT_EN], 0); > } > > -int get_temp_tsens_valid(struct tsens_sensor *s, int *temp) > +int get_temp_tsens_valid(const struct tsens_sensor *s, int *temp) > { > struct tsens_priv *priv = s->priv; > int hw_id = s->hw_id; > @@ -486,7 +486,7 @@ int get_temp_tsens_valid(struct tsens_sensor *s, int *temp) > return 0; > } > > -int get_temp_common(struct tsens_sensor *s, int *temp) > +int get_temp_common(const struct tsens_sensor *s, int *temp) > { > struct tsens_priv *priv = s->priv; > int hw_id = s->hw_id; > diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h > index be364bf1d5a6..70dc34c80537 100644 > --- a/drivers/thermal/qcom/tsens.h > +++ b/drivers/thermal/qcom/tsens.h > @@ -67,7 +67,7 @@ struct tsens_ops { > /* mandatory callbacks */ > int (*init)(struct tsens_priv *priv); > int (*calibrate)(struct tsens_priv *priv); > - int (*get_temp)(struct tsens_sensor *s, int *temp); > + int (*get_temp)(const struct tsens_sensor *s, int *temp); > /* optional callbacks */ > int (*enable)(struct tsens_priv *priv, int i); > void (*disable)(struct tsens_priv *priv); > @@ -494,8 +494,8 @@ struct tsens_priv { > char *qfprom_read(struct device *dev, const char *cname); > void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mode); > int init_common(struct tsens_priv *priv); > -int get_temp_tsens_valid(struct tsens_sensor *s, int *temp); > -int get_temp_common(struct tsens_sensor *s, int *temp); > +int get_temp_tsens_valid(const struct tsens_sensor *s, int *temp); > +int get_temp_common(const struct tsens_sensor *s, int *temp); > int tsens_enable_irq(struct tsens_priv *priv); > void tsens_disable_irq(struct tsens_priv *priv); > int tsens_set_trips(void *_sensor, int low, int high); > -- > 2.20.1 >