From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA5CEC33CAB for ; Mon, 13 Jan 2020 08:34:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 910EC22527 for ; Mon, 13 Jan 2020 08:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578904448; bh=9jMvUvSvJlkAqTVszqCKOcIot5UUibmC3ED/ano5fAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=koP6MzJVyi462WXYqzhZ/544HZz5G2oz3gSNKGVYlabY0MFd+EZBn6YhxfRkwy1k3 lWEyHdavTSkSghLrjSLWsp1ImUWzm/IAM47FHDsWvw977cs/ClstDZBRIyhZpcPbp4 zbBMsTttCmin8G+hACTDPPJqAxAHiihDYu5pnthM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728765AbgAMIeI (ORCPT ); Mon, 13 Jan 2020 03:34:08 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35425 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728699AbgAMIeI (ORCPT ); Mon, 13 Jan 2020 03:34:08 -0500 Received: by mail-ed1-f65.google.com with SMTP id f8so7708906edv.2; Mon, 13 Jan 2020 00:34:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pwiky2V1HXRMgUMF8ZYenJSpk8xqF9IZsi12qqtxDSo=; b=fd5DUeIDDm+CQTs37RXNuHsLos0XQ7KTVgM4m3jBRdz9BG3CjjEvOGam+l/fNpHmEe rQXy+DS5Q+saka31qhZmDF16fxtQHpDBdXk5vspxkcdCh+In7ichPQQKK+bvXxaF7oDs v16ZKejP86ci/iAGwkn2FQoBaJT0K3U8I4LwRdVtc+Irf+6iCxFdw+KFMKUljKPVvUmv xaBmPWMJeKuFstg96LB9Wocd4aPVkrlxDOYDqegrhEt+tjQqsdmfTrF6ygOm3hRVwpG0 q3w4krAZBXtdGiF0vLO88H0KcxFsJNHPvZSI/j6DaLfzsYmKPjS3XeKPYMZCXGhL2DY5 IE1w== X-Gm-Message-State: APjAAAXiMxbt8EnWFI+aHLZBaTdX30VrumHt7BDHbh3X6776V3njcnCV ZZBzX7RsN2ZmcaSktv62x6UZzg7sw6Y= X-Google-Smtp-Source: APXvYqzUQpNNjJExK/G4N7n06llOe2EgioVrrlEkmNYk0/kj7RSvUBziADQn4BpMSCo3rhZmQYBPWA== X-Received: by 2002:a17:906:66c9:: with SMTP id k9mr12247747ejp.341.1578904445904; Mon, 13 Jan 2020 00:34:05 -0800 (PST) Received: from pi3 ([194.230.155.229]) by smtp.googlemail.com with ESMTPSA id m5sm399916ede.10.2020.01.13.00.34.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 00:34:05 -0800 (PST) Date: Mon, 13 Jan 2020 09:34:03 +0100 From: Krzysztof Kozlowski To: Marek Szyprowski Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , Matheus Castello , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] power: supply: max17040: Correct IRQ wake handling Message-ID: <20200113083403.GA1320@pi3> References: <20200110100540.27371-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200110100540.27371-1-m.szyprowski@samsung.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Jan 10, 2020 at 11:05:40AM +0100, Marek Szyprowski wrote: > Don't disable IRQ wake feature without prior enabling it. > > This fixes following warning observed on Exynos3250-based Rinato board: > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1288 at kernel/irq/manage.c:724 irq_set_irq_wake+0xfc/0x134 > Unbalanced IRQ 83 wake disable > Modules linked in: > CPU: 0 PID: 1288 Comm: rtcwake Not tainted 5.5.0-rc5-next-20200110-00031-g6289fffbb3f5 #7266 > Hardware name: Samsung Exynos (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0xa4/0xd0) > [] (dump_stack) from [] (__warn+0xf4/0x10c) > [] (__warn) from [] (warn_slowpath_fmt+0x74/0xb8) > [] (warn_slowpath_fmt) from [] (irq_set_irq_wake+0xfc/0x134) > [] (irq_set_irq_wake) from [] (max17040_suspend+0x50/0x58) > [] (max17040_suspend) from [] (dpm_run_callback+0xb4/0x400) > [] (dpm_run_callback) from [] (__device_suspend+0x140/0x814) > [] (__device_suspend) from [] (dpm_suspend+0x16c/0x564) > [] (dpm_suspend) from [] (dpm_suspend_start+0x90/0x98) > [] (dpm_suspend_start) from [] (suspend_devices_and_enter+0xec/0xc0c) > [] (suspend_devices_and_enter) from [] (pm_suspend+0x318/0x3e8) > [] (pm_suspend) from [] (state_store+0x68/0xc8) > [] (state_store) from [] (kernfs_fop_write+0x10c/0x220) > [] (kernfs_fop_write) from [] (__vfs_write+0x2c/0x1c4) > [] (__vfs_write) from [] (vfs_write+0xa4/0x180) > [] (vfs_write) from [] (ksys_write+0x58/0xcc) > [] (ksys_write) from [] (ret_fast_syscall+0x0/0x28) > Exception stack(0xd6e83fa8 to 0xd6e83ff0) > ... > irq event stamp: 18028 > hardirqs last enabled at (18027): [] cancel_delayed_work+0x84/0xf8 > hardirqs last disabled at (18028): [] _raw_spin_lock_irqsave+0x1c/0x58 > softirqs last enabled at (17876): [] __do_softirq+0x4f0/0x5e4 > softirqs last disabled at (17869): [] irq_exit+0x16c/0x170 > ---[ end trace 0728005730004e60 ]--- > > Fixes: 2e17ed94de68 ("power: supply: max17040: Add IRQ handler for low SOC alert") > Signed-off-by: Marek Szyprowski > --- > drivers/power/supply/max17040_battery.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof