From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5D0FC32771 for ; Wed, 15 Jan 2020 18:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E9BA2465A for ; Wed, 15 Jan 2020 18:39:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech-se.20150623.gappssmtp.com header.i=@ragnatech-se.20150623.gappssmtp.com header.b="aj7b4wZM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgAOSjo (ORCPT ); Wed, 15 Jan 2020 13:39:44 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:37350 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728993AbgAOSjo (ORCPT ); Wed, 15 Jan 2020 13:39:44 -0500 Received: by mail-lf1-f67.google.com with SMTP id b15so13504017lfc.4 for ; Wed, 15 Jan 2020 10:39:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=zXVPagk9qy6y1pvhnWsVit2PeslU4wNbSMADm371SMA=; b=aj7b4wZMsmzA/j5jJk0eKoPAbxmen1HlcPaI3zqGFb7zqb4T4zPXtek0Iv/FvRVEuw V0H2lPqNZptjw+8JXVznLeuYNHDqg6lIviGqr61W/bW5YlVA+yI1UVVfIpShh/OtQOVl Zp9XicUCnP8CdkU8cQED9Q0QP/np6sYi7HSTu/XG7IDjj6OMQ5xfPxKdBnctdOCNL4PX VOr11WEvexBioKDMriayxGNH2V6r5aVn5JHD843MjMtt9JbGGNmfdQ2XyaJSLxyc6XcW 9pag2DjD43LS9hpmMaqvQ15QN7QKQD5EtAJHWP44YrPxpDrj6WTMCMkfPweR5VoP096T tqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=zXVPagk9qy6y1pvhnWsVit2PeslU4wNbSMADm371SMA=; b=Xn9ucr47sf+1PdEwNKVsAepatbCi182q2CYpPxrt+AGkVO2KDThL/T8xmY16eSvxbF SHtiEJDJGNPIXyScGjyCMli+UAZ+gGU6jxEN2vq/cMQqJP7giyOUXtyhVut9Rzd7PVV6 wlfFod9hMx2tfvsY9TpKgxcVcN33czrLli4hBawPBiYF1LMMpXSyghEebkP6NF61p824 L7tbayKdvqM8Sljj+zPK7U9hpk/WeDLx8TrXosM+cyIkRl/6tGC9RejGw0S2ziqR5Hh3 UeY8sDoFR80NzF7MNYPf9ZaeMNe1cIniReUJljJ0BSEMG+q52gq4QgRpYbr2K4Dl7IfL +5Ug== X-Gm-Message-State: APjAAAX1bRVCCkz/NGjQzbrbzXR7A/jmIhfseNznnxLDDk8r4+4ZjF9o uhgfWOSM/lT40uDShDkSTUFM5EKIB88= X-Google-Smtp-Source: APXvYqx3o1geG9DVN0+yWVxPH0U1oYe+kMH4w2sGpk9818GWZ5uKiP2U9GaNpKvS32E35/1CF+eZVg== X-Received: by 2002:ac2:544f:: with SMTP id d15mr172788lfn.126.1579113582544; Wed, 15 Jan 2020 10:39:42 -0800 (PST) Received: from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159]) by smtp.gmail.com with ESMTPSA id 140sm9469856lfk.78.2020.01.15.10.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 10:39:41 -0800 (PST) Date: Wed, 15 Jan 2020 19:39:40 +0100 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Daniel Lezcano Cc: linux-pm@vger.kernel.org, Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 1/2] thermal: rcar_thermal: Remove temperature bound Message-ID: <20200115183940.GA979534@oden.dyn.berto.se> References: <20200114222945.3128250-1-niklas.soderlund+renesas@ragnatech.se> <20200114222945.3128250-2-niklas.soderlund+renesas@ragnatech.se> <20200115134559.GA945270@oden.dyn.berto.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Daniel, On 2020-01-15 19:15:11 +0100, Daniel Lezcano wrote: > On 15/01/2020 14:45, Niklas Söderlund wrote: > > Hi Daniel, > > > > Thanks for your feedback. > > > > On 2020-01-15 14:24:30 +0100, Daniel Lezcano wrote: > >> On 14/01/2020 23:29, Niklas Söderlund wrote: > >>> The hardware manual states that the operation of the sensor is not > >>> guaranteed outside the range of -40°C to 125°C, not that the readings > >>> are invalid. Remove the bound check and try to deliver temperature > >>> readings even if we are outside the guaranteed operation range. > >> > >> And what if the sensor is returning crap in this out-of-range operation? > > > > I'm not sure what is worse, reporting an untrue (but still outside the > > guaranteed operation range) extreme temperature or failing with -EIO. > > The view of the hardware guys is that it's better to report what the > > sensor indicates then to return -EIO. > > I don't get the point. > > What happens if we read the sensor while it is above or below the limits? The manual describes the read outs as being +/- 2°C from the true temperature for the guaranteed operating range. Outside this range the difference between the true temperature and the read out temperature might be larger than 2°C. > > > [ ... ] > > > > -- > Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: Facebook | > Twitter | > Blog > -- Regards, Niklas Söderlund