From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A6BBC35247 for ; Mon, 3 Feb 2020 18:14:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA59020CC7 for ; Mon, 3 Feb 2020 18:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DtX5C74m" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729342AbgBCSOT (ORCPT ); Mon, 3 Feb 2020 13:14:19 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:40305 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728923AbgBCSOS (ORCPT ); Mon, 3 Feb 2020 13:14:18 -0500 Received: by mail-pf1-f196.google.com with SMTP id q8so7974535pfh.7 for ; Mon, 03 Feb 2020 10:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IVwPeQjWnavkYSmreRihBcQCqzcKg6GvGjN7vrooL6I=; b=DtX5C74mzvURRslkfhYTbEWniKOBw9KEJSR3cHSmYH69gU2PWjEz+geJRVgphNtLbk F6crXZWVvIdzHd6d4EfPrqX5UJROzbjwFQrlC+pCco5HrIMJbpSt/hyytkolvwhtzHls ldq23iqkmxJ99PzYXSMzkMqK4tpGoQ6IRRR3ogFKz1EO1FCjYrW0lEQf4+3jvUypIUGK Ldx1tW5YsUZQaFfqc7+xet3qac+Lxs3QEyJiqXdlNRR6m0hF3vQ1u3isU5mAevs3Zlo2 UwN564q2bAIua7iFzbObi5cErmMrfSPIuGQjXotXeyxw5IRUtRDGEygMrHBh+HZ1GTBR 6I5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IVwPeQjWnavkYSmreRihBcQCqzcKg6GvGjN7vrooL6I=; b=Hp2QTUk6f1RjYtlX6OAAx6RT6impR5E1p/9lAx4Jnm0wiZO2oqo2yd2Ic/mAk3ytp9 aXbtbZrfl5PQejiyyqU7jNj5bfE+iK5UuHzNOTWA4D8ihzPCI+uNX1carBFvmt1E8ZhL Shh5COg/ZRkkDbKKYuf4g4Lm25/8WnKdSGV/Yz3y+y971lFA6j2RLhpyz8zphROFwR4+ VPhVjUgs5kfT3YFtSwZJavy3/2OC4ndMCzhAKU+ww6/sXrcVd7pg/fXN6ezHXN2pYa5M 9uijcRzWlpHjGDnMjyB2emF61khjqTRTKiQlgJJAJYR7wLneT18b/OK2FyMwf+Hwjrbx OAbg== X-Gm-Message-State: APjAAAVdmdwiYwUNNhtMWQLnfDnDGl0oDzyLPxXcJwEivyD0R5QcerFx Ox2EBRRZMRpq6zofsvH1KnJDHw== X-Google-Smtp-Source: APXvYqxkgpl/cr1CnUuiWJNV7TN7ZP1AWB4FhxD0zzu8YMafzUAWo/WgGlqMypt9vpgwtQ17L8/NPg== X-Received: by 2002:a63:7949:: with SMTP id u70mr25980401pgc.233.1580753656675; Mon, 03 Feb 2020 10:14:16 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id z14sm19775106pgj.43.2020.02.03.10.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 10:14:15 -0800 (PST) Date: Mon, 3 Feb 2020 10:14:13 -0800 From: Bjorn Andersson To: Amit Kucheria Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, swboyd@chromium.org, sivaa@codeaurora.org, Andy Gross , Amit Kucheria , linux-pm@vger.kernel.org Subject: Re: [PATCH v4 4/7] drivers: thermal: tsens: Add critical interrupt support Message-ID: <20200203181413.GF3948@builder> References: <932e07a83fed192678b8f718bbae37d0dc83590d.1580390127.git.amit.kucheria@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <932e07a83fed192678b8f718bbae37d0dc83590d.1580390127.git.amit.kucheria@linaro.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote: > TSENS IP v2.x adds critical threshold interrupt support for each sensor > in addition to the upper/lower threshold interrupt. Add support in the > driver. > > While the critical interrupts themselves aren't currently used by Linux, > the HW line is also used by the TSENS watchdog. So this patch acts as > infrastructure to enable watchdog functionality for the TSENS IP. > > Signed-off-by: Amit Kucheria > --- Please do provide a changelog when respinning your patches. > drivers/thermal/qcom/tsens-common.c | 120 ++++++++++++++++++++++++++-- > drivers/thermal/qcom/tsens-v2.c | 8 +- > drivers/thermal/qcom/tsens.c | 24 +++++- > drivers/thermal/qcom/tsens.h | 71 ++++++++++++++++ > 4 files changed, 212 insertions(+), 11 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c [..] > +irqreturn_t tsens_critical_irq_thread(int irq, void *data) > +{ > + struct tsens_priv *priv = data; > + struct tsens_irq_data d; > + unsigned long flags; > + int temp, ret, i; > + > + for (i = 0; i < priv->num_sensors; i++) { > + const struct tsens_sensor *s = &priv->sensor[i]; > + u32 hw_id = s->hw_id; > + > + if (IS_ERR(s->tzd)) > + continue; > + if (!tsens_threshold_violated(priv, hw_id, &d)) > + continue; > + ret = get_temp_tsens_valid(s, &temp); > + if (ret) { > + dev_err(priv->dev, "[%u] %s: error reading sensor\n", hw_id, __func__); > + continue; > + } > + > + spin_lock_irqsave(&priv->crit_lock, flags); > + I see that I failed to follow up on the discussion on the previous revision. The handler is called from a single thread, so you don't need a lock to protect the irq handler from itself. Regards, Bjorn