From: Mark Brown <broonie@kernel.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>, Pavel Machek <pavel@ucw.cz>,
Len Brown <len.brown@intel.com>, Todd Kjos <tkjos@google.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] driver core: Make deferred_probe_timeout global so it can be shared
Date: Wed, 19 Feb 2020 11:59:42 +0000 [thread overview]
Message-ID: <20200219115942.GA4488@sirena.org.uk> (raw)
In-Reply-To: <20200218220748.54823-2-john.stultz@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]
On Tue, Feb 18, 2020 at 10:07:48PM +0000, John Stultz wrote:
> This patch, suggested by Rob, allows deferred_probe_timeout to
> be global so other substems can use it.
> This also sets the default to 30 instead of -1 (no timeout) and
> modifies the regulator code to make use of it instead of its
> hard-coded 30 second interval.
This is at least two patches, one adding the new feature and the other
adding a user of that feature.
> @@ -5767,18 +5772,17 @@ static int __init regulator_init_complete(void)
> has_full_constraints = true;
>
> /*
> - * We punt completion for an arbitrary amount of time since
> + * We punt completion for deferred_probe_timeout seconds since
> * systems like distros will load many drivers from userspace
> * so consumers might not always be ready yet, this is
> * particularly an issue with laptops where this might bounce
While I don't see it doing any harm I'm not 100% convinced by this
change - we're not really doing anything directly to do with deferred
probe here, we're shutting off regulators that remain unused late in
boot but even then they'll still be available for use. It feels a bit
unclear and the way you've adapted the code to always have a timeout
even if the deferred probe timeout gets changed feels a bit off. If
nothing else this comment needs more of an update than you've done.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-19 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:07 [PATCH v3 1/2] driver core: Rework logic in __driver_deferred_probe_check_state to allow EPROBE_DEFER to be returned for longer John Stultz
2020-02-18 22:07 ` [PATCH v3 2/2] driver core: Make deferred_probe_timeout global so it can be shared John Stultz
2020-02-19 7:57 ` Greg Kroah-Hartman
2020-02-19 8:00 ` Randy Dunlap
2020-02-19 8:15 ` Greg Kroah-Hartman
2020-02-19 11:59 ` Mark Brown [this message]
2020-02-19 21:15 ` John Stultz
2020-02-18 22:51 ` [PATCH v3 1/2] driver core: Rework logic in __driver_deferred_probe_check_state to allow EPROBE_DEFER to be returned for longer Rob Herring
2020-02-18 23:21 ` John Stultz
2020-02-18 23:53 ` Rob Herring
2020-02-18 23:57 ` Mark Brown
2020-02-18 23:58 ` John Stultz
2020-02-19 0:15 ` Mark Brown
[not found] ` <CAHp75VcPL7DYp9hjgMu+d=CE=g+V7ZxT9ZyXX-OjEW_JQ4m_nA@mail.gmail.com>
2020-02-19 0:19 ` John Stultz
2020-02-19 1:11 ` John Stultz
2020-02-19 2:07 ` Rob Herring
2020-02-19 4:23 ` John Stultz
2020-02-20 5:27 ` Saravana Kannan
2020-02-20 10:09 ` Andy Shevchenko
2020-02-20 21:06 ` Saravana Kannan
2020-02-20 15:20 ` Rob Herring
2020-02-20 23:07 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219115942.GA4488@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=tkjos@google.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).