From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8465C10F25 for ; Fri, 6 Mar 2020 14:23:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB27E2072D for ; Fri, 6 Mar 2020 14:23:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726846AbgCFOXe (ORCPT ); Fri, 6 Mar 2020 09:23:34 -0500 Received: from foss.arm.com ([217.140.110.172]:34598 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726798AbgCFOXe (ORCPT ); Fri, 6 Mar 2020 09:23:34 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9797031B; Fri, 6 Mar 2020 06:23:33 -0800 (PST) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 137363F534; Fri, 6 Mar 2020 06:23:31 -0800 (PST) Date: Fri, 6 Mar 2020 14:23:30 +0000 From: Sudeep Holla To: Benjamin Gaignard Cc: Ulf Hansson , Lorenzo Pieralisi , Benjamin Gaignard , Linux PM , Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Sudeep Holla , Linux ARM Subject: Re: [PATCH v2 4/4] cpuidle: psci: Allow WFI to be the only state for the hierarchical topology Message-ID: <20200306134119.GB47929@bogus> References: <20200303203559.23995-1-ulf.hansson@linaro.org> <20200303203559.23995-5-ulf.hansson@linaro.org> <20200304122312.GE25004@bogus> <20200305162321.GB53631@bogus> <20200306100431.GA16541@bogus> <20200306120646.GB44221@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, Mar 06, 2020 at 01:32:59PM +0100, Benjamin Gaignard wrote: > Le ven. 6 mars 2020 à 13:06, Sudeep Holla a écrit : > > [...] > > Sure, please create a deeper CPU state than WFI and enter so that the CPU > > state is saved and restored correctly. What is the problem doing that ? > > This state stop the clocks for all the hardware blocks and not only the CPUs > so we can't go on it while devices aren't suspended. > I may have missed something but I don't believe that I could add this kind of > conditions in a cpu idle state, right ? > In this state I need to be able to enable the wake up sources because > it is the only > for hardware block used as broadcast timer to wake up the system. > We have discussed this in past in the thread I mentioned and may be others too. It sounds like a broken hardware, sorry if I am wrong. But this $subject patch is a hack to solve that and I am NACK-ing this now. Please fix it adding another CPU level idle state, we are not supporting without that and there is absolutely no need to. -- Regards, Sudeep