* Re: linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c)
[not found] ` <1c7d78ba-55ae-6f8c-9a4f-13aca32f59de@infradead.org>
@ 2020-03-19 3:20 ` Stephen Rothwell
2020-03-19 14:47 ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Christian Brauner
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Rothwell @ 2020-03-19 3:20 UTC (permalink / raw)
To: Christian Brauner
Cc: Randy Dunlap, Linux Next Mailing List, Linux Kernel Mailing List,
Greg Kroah-Hartman, Rafael J. Wysocki, Linux PM list,
David S. Miller
[-- Attachment #1: Type: text/plain, Size: 3283 bytes --]
Hi Randy,
On Wed, 18 Mar 2020 09:14:29 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>
> on i386:
>
> ../drivers/base/power/sysfs.c: In function ‘dpm_sysfs_change_owner’:
> ../drivers/base/power/sysfs.c:708:44: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> rc = sysfs_group_change_owner(&dev->kobj, &pm_attr_group, kuid, kgid);
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:714:16: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> &dev->kobj, &pm_runtime_attr_group, kuid, kgid);
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:720:45: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> rc = sysfs_group_change_owner(&dev->kobj, &pm_wakeup_attr_group,
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/base/power/sysfs.c:732:16: error: passing argument 2 of ‘sysfs_group_change_owner’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> &dev->kobj, &pm_qos_latency_tolerance_attr_group, kuid,
> ^
> In file included from ../include/linux/kobject.h:20:0,
> from ../include/linux/device.h:17,
> from ../drivers/base/power/sysfs.c:3:
> ../include/linux/sysfs.h:576:19: note: expected ‘const struct attribute_group **’ but argument is of type ‘const struct attribute_group *’
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> ^~~~~~~~~~~~~~~~~~~~~~~~
Caused by commitCONFIG_SYSFS
303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
from the net-next tree.
The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
from the !CONFIG_SYSFS version.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner()
2020-03-19 3:20 ` linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c) Stephen Rothwell
@ 2020-03-19 14:47 ` Christian Brauner
2020-03-19 16:19 ` Randy Dunlap
2020-03-20 4:17 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Christian Brauner @ 2020-03-19 14:47 UTC (permalink / raw)
To: David S. Miller, Greg Kroah-Hartman, netdev, linux-kernel
Cc: Rafael J. Wysocki, Pavel Machek, Jakub Kicinski, Eric Dumazet,
Stephen Hemminger, linux-pm, Randy Dunlap,
Linux Next Mailing List, Stephen Rothwell, Christian Brauner
The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
from the !CONFIG_SYSFS version and thus causes build failurs when
!CONFIG_SYSFS is set.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---
include/linux/sysfs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index 9e531ec76274..4beb51009b62 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj,
}
static inline int sysfs_group_change_owner(struct kobject *kobj,
- const struct attribute_group **groups,
- kuid_t kuid, kgid_t kgid)
+ const struct attribute_group *groups,
+ kuid_t kuid, kgid_t kgid)
{
return 0;
}
base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db
--
2.25.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner()
2020-03-19 14:47 ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Christian Brauner
@ 2020-03-19 16:19 ` Randy Dunlap
2020-03-20 4:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2020-03-19 16:19 UTC (permalink / raw)
To: Christian Brauner, David S. Miller, Greg Kroah-Hartman, netdev,
linux-kernel
Cc: Rafael J. Wysocki, Pavel Machek, Jakub Kicinski, Eric Dumazet,
Stephen Hemminger, linux-pm, Linux Next Mailing List,
Stephen Rothwell
On 3/19/20 7:47 AM, Christian Brauner wrote:
> The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
> from the !CONFIG_SYSFS version and thus causes build failurs when
> !CONFIG_SYSFS is set.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
> Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Thanks.
> ---
> include/linux/sysfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
> index 9e531ec76274..4beb51009b62 100644
> --- a/include/linux/sysfs.h
> +++ b/include/linux/sysfs.h
> @@ -562,8 +562,8 @@ static inline int sysfs_groups_change_owner(struct kobject *kobj,
> }
>
> static inline int sysfs_group_change_owner(struct kobject *kobj,
> - const struct attribute_group **groups,
> - kuid_t kuid, kgid_t kgid)
> + const struct attribute_group *groups,
> + kuid_t kuid, kgid_t kgid)
> {
> return 0;
> }
>
> base-commit: 79e28519ac78dde6d38fe6ea22286af574f5c7db
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner()
2020-03-19 14:47 ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Christian Brauner
2020-03-19 16:19 ` Randy Dunlap
@ 2020-03-20 4:17 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-20 4:17 UTC (permalink / raw)
To: christian.brauner
Cc: gregkh, netdev, linux-kernel, rafael, pavel, kuba, edumazet,
stephen, linux-pm, rdunlap, linux-next, sfr
From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Thu, 19 Mar 2020 15:47:41 +0100
> The CONFIG_SYSFS declaration of sysfs_group_change_owner() is different
> from the !CONFIG_SYSFS version and thus causes build failurs when
> !CONFIG_SYSFS is set.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 303a42769c4c ("sysfs: add sysfs_group{s}_change_owner()")
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-20 4:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200318220920.48df2e76@canb.auug.org.au>
[not found] ` <1c7d78ba-55ae-6f8c-9a4f-13aca32f59de@infradead.org>
2020-03-19 3:20 ` linux-next: Tree for Mar 18 (drivers/base/power/sysfs.c) Stephen Rothwell
2020-03-19 14:47 ` [PATCH net-next] sysfs: fix static inline declaration of sysfs_groups_change_owner() Christian Brauner
2020-03-19 16:19 ` Randy Dunlap
2020-03-20 4:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).