From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93198C4332B for ; Sat, 21 Mar 2020 14:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E92B20776 for ; Sat, 21 Mar 2020 14:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727428AbgCUOrO (ORCPT ); Sat, 21 Mar 2020 10:47:14 -0400 Received: from muru.com ([72.249.23.125]:32876 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726652AbgCUOrO (ORCPT ); Sat, 21 Mar 2020 10:47:14 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 97DA6810E; Sat, 21 Mar 2020 14:48:00 +0000 (UTC) Date: Sat, 21 Mar 2020 07:47:10 -0700 From: Tony Lindgren To: Arthur Demchenkov Cc: Merlijn Wajer , Pavel Machek , sre@kernel.org, linux-pm@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 03/15] power: supply: cpcap-battery: Fix battery low status reporting Message-ID: <20200321144710.GV37466@atomide.com> References: <20200315151206.30909-1-spinal.by@gmail.com> <20200315151206.30909-3-spinal.by@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200315151206.30909-3-spinal.by@gmail.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org * Arthur Demchenkov [200315 15:15]: > If we hit battery low once, we should stick on reporting it until the > charger is connected. This way low->counter_uah will be updated > properly, and that will allow us to get more accurate charge_full value. > > Signed-off-by: Arthur Demchenkov > --- > drivers/power/supply/cpcap-battery.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c > index 52f03a2662a5..8a58ad943960 100644 > --- a/drivers/power/supply/cpcap-battery.c > +++ b/drivers/power/supply/cpcap-battery.c > @@ -421,11 +421,14 @@ static bool cpcap_battery_full(struct cpcap_battery_ddata *ddata) > static bool cpcap_battery_low(struct cpcap_battery_ddata *ddata) > { > struct cpcap_battery_state_data *state = cpcap_battery_latest(ddata); > + static bool is_low; > > - if (state->current_ua && state->voltage <= 3300000) > - return true; > + if (state->current_ua > 0 && (state->voltage <= 3300000 || is_low)) > + is_low = true; > + else > + is_low = false; > > - return false; > + return is_low; > } Please set up bitmask in ddata for unsigned int battery_low:1; instead of using a static variable here. If we ever had two instances of cpcap on the same device the static variable here would not work :) Regards, Tony