From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Ferry Toth <fntoth@gmail.com>
Subject: Re: [PATCH v2 1/3] driver core: Break infinite loop when deferred probe can't be satisfied
Date: Tue, 24 Mar 2020 17:47:01 +0200 [thread overview]
Message-ID: <20200324154701.GQ1922688@smile.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gcLkymFNktG=46rxRc=KUGyztxYXmSZ51UxkKM6POnow@mail.gmail.com>
On Tue, Mar 24, 2020 at 04:36:56PM +0100, Rafael J. Wysocki wrote:
> On Tue, Mar 24, 2020 at 2:39 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Tue, Mar 24, 2020 at 01:52:00PM +0100, Rafael J. Wysocki wrote:
> > > On Tue, Mar 24, 2020 at 1:20 PM Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com> wrote:
...
> > > > + atomic_dec(&probe_okay);
> > >
> > > Why is this needed?
> >
> > Under successful probe the following is comprehended. When probe of the driver
> > happens it may be discarded (as in above case) as it was initiated by another
> > driver which got deferred.
> >
> > We also discussed this with Peter [1] during his review.
> >
> > [1]: https://lkml.org/lkml/2020/3/12/347
>
> OK, but I would add a comment explaining that to the code.
>
> Also it would be good to explain why probe_okay cannot go below zero
> here in the changelog.
Will do, thank you for review!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-03-24 15:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 12:20 [PATCH v2 1/3] driver core: Break infinite loop when deferred probe can't be satisfied Andy Shevchenko
2020-03-24 12:20 ` [PATCH v2 2/3] driver core: Read atomic counter once in driver_probe_done() Andy Shevchenko
2020-03-24 12:55 ` Rafael J. Wysocki
2020-03-24 12:20 ` [PATCH v2 3/3] driver core: Replace open-coded list_last_entry() Andy Shevchenko
2020-03-24 12:53 ` Rafael J. Wysocki
2020-03-27 17:56 ` Naresh Kamboju
2020-03-27 19:40 ` Robin Murphy
2020-03-30 10:13 ` Sudeep Holla
2020-03-30 10:43 ` Andy Shevchenko
2020-03-30 13:16 ` Sudeep Holla
2020-03-30 12:45 ` Robin Murphy
2020-03-30 13:11 ` Andy Shevchenko
2020-03-30 13:29 ` Robin Murphy
2020-03-30 20:02 ` John Stultz
2020-03-30 13:25 ` Sudeep Holla
2020-03-28 7:25 ` Greg Kroah-Hartman
2020-03-24 12:52 ` [PATCH v2 1/3] driver core: Break infinite loop when deferred probe can't be satisfied Rafael J. Wysocki
2020-03-24 13:39 ` Andy Shevchenko
2020-03-24 15:36 ` Rafael J. Wysocki
2020-03-24 15:47 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324154701.GQ1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.hajda@samsung.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=balbi@kernel.org \
--cc=broonie@kernel.org \
--cc=fntoth@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).