linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	linux-s390@vger.kernel.org, Linux PM <linux-pm@vger.kernel.org>
Subject: Re: s390: removal of hibernate support
Date: Tue, 24 Mar 2020 20:11:28 +0100	[thread overview]
Message-ID: <20200324191128.GA3822@osiris> (raw)
In-Reply-To: <CAJZ5v0hzf=kQBcR=K2KL1kEVtA6oLPtLDaeeaVuWMPsXomhJHw@mail.gmail.com>

Hi Rafael,

> On Mon, Mar 23, 2020 at 7:12 PM Heiko Carstens
> <heiko.carstens@de.ibm.com> wrote:
> > we are going to remove hibernate support on s390, since it is
> > - broken since many years
> > - there is no real use case which justifies keeping and maintaining
> >   the code
> >
> > See also https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=394216275c7d503d966317da9a01ad6626a6091d
> >
> > This in turn allows also to remove s390 specific hooks in generic
> > power management code (see patch below). The patch below is currently
> > also on the same features branch.
> > I silently assume(d) that you don't mind to get rid of otherwise dead
> > code, or do you have any objections?
> >
> > From 086b2d78375cffe58f5341359bebec0650793811 Mon Sep 17 00:00:00 2001
> > From: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Date: Wed, 18 Mar 2020 20:55:20 +0100
> > Subject: [PATCH] PM: remove s390 specific callbacks
> >
> > ARCH_SAVE_PAGE_KEYS has been introduced in order to be able to save
> > and restore s390 specific storage keys into a hibernation image.
> > With hibernation support removed from s390 there is no point in
> > keeping the callbacks.
> >
> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>
> > Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
> 
> Can I take this patch or would it be better to route it differently?

The patch is already on the s390 features branch and is supposed to be
part of the first pull request for the next merge window (actually the
patch is already in linux-next).
So I'd say the easiest thing would be to route it through the s390 tree.


  reply	other threads:[~2020-03-24 19:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-23 18:12 s390: removal of hibernate support Heiko Carstens
2020-03-24 15:40 ` Rafael J. Wysocki
2020-03-24 19:11   ` Heiko Carstens [this message]
2020-03-24 22:07     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324191128.GA3822@osiris \
    --to=heiko.carstens@de.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=oberpar@linux.ibm.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).