From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE743C352B6 for ; Tue, 14 Apr 2020 08:25:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1FB52074D for ; Tue, 14 Apr 2020 08:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436754AbgDNIZi (ORCPT ); Tue, 14 Apr 2020 04:25:38 -0400 Received: from foss.arm.com ([217.140.110.172]:50906 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436753AbgDNIZe (ORCPT ); Tue, 14 Apr 2020 04:25:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 81E131FB; Tue, 14 Apr 2020 01:25:32 -0700 (PDT) Received: from bogus (unknown [10.37.12.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 855603F73D; Tue, 14 Apr 2020 01:25:23 -0700 (PDT) Date: Tue, 14 Apr 2020 09:25:20 +0100 From: Sudeep Holla To: Jiaxun Yang Cc: linux-mips@vger.kernel.org, dietmar.eggemann@arm.com, Thomas Bogendoerfer , Huacai Chen , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Florian Fainelli , Robert Richter , Greg Kroah-Hartman , "Rafael J. Wysocki" , Daniel Lezcano , Thomas Gleixner , Jason Cooper , Marc Zyngier , Paul Burton , Allison Randal , Enrico Weigelt , Kate Stewart , Vladimir Kondratiev , Alexios Zavras , Paul Cercueil , Zhou Yanjie , =?utf-8?B?5ZGo55Cw5p2wIChaaG91IFlhbmppZSk=?= , YunQiang Su , Arnd Bergmann , Serge Semin , Matt Redfearn , Richard Fontana , Steve Winslow , afzal mohammed , Peter Xu , Kamal Dasu , Oleksij Rempel , Sudeep Holla , Mike Rapoport , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, oprofile-list@lists.sf.net, linux-pm@vger.kernel.org Subject: Re: [PATCH v2 03/11] arch_topology: Make it avilable for MIPS Message-ID: <20200414082520.GB6459@bogus> References: <20200412032123.3896114-1-jiaxun.yang@flygoat.com> <20200412032123.3896114-4-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200412032123.3896114-4-jiaxun.yang@flygoat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Apr 12, 2020 at 11:20:33AM +0800, Jiaxun Yang wrote: > Simply drop unnecessary archtecture limitions and add dummy > function for platforms without OF support. > As some of the functions are conflicting with Arm's platform > implementations, we mark them as weak. > > Signed-off-by: Jiaxun Yang > -- > v2: Use weak instead of ifdef to exclude functions for Arm. > --- > drivers/base/arch_topology.c | 116 ++++++++++++++++++----------------- > 1 file changed, 60 insertions(+), 56 deletions(-) > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 4d0a0038b476..13dc4fbf043f 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -143,57 +143,6 @@ void topology_normalize_cpu_scale(void) > } > } > > -bool __init topology_parse_cpu_capacity(struct device_node *cpu_node, int cpu) This function is not under any #ifdefery and you are adding it but the commit message indicates opposite. Please state the reason why this needs to be moved under #ifdef -- Regards, Sudeep