From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24EDAC55185 for ; Wed, 22 Apr 2020 11:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D2FB2077D for ; Wed, 22 Apr 2020 11:01:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727897AbgDVLBp (ORCPT ); Wed, 22 Apr 2020 07:01:45 -0400 Received: from foss.arm.com ([217.140.110.172]:47584 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbgDVLBo (ORCPT ); Wed, 22 Apr 2020 07:01:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B267231B; Wed, 22 Apr 2020 04:01:43 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 905FE3F6CF; Wed, 22 Apr 2020 04:01:43 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 35482682F3D; Wed, 22 Apr 2020 12:01:42 +0100 (BST) Date: Wed, 22 Apr 2020 12:01:42 +0100 From: Liviu Dudau To: Rob Herring Cc: Linus Walleij , Lorenzo Pieralisi , Sudeep Holla , Arnd Bergmann , Catalin Marinas , Greg Kroah-Hartman , Lee Jones , Sebastian Reichel , Stephen Boyd , Will Deacon , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Michael Turquette Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module Message-ID: <20200422110142.GT364558@e110455-lin.cambridge.arm.com> References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-9-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200419170810.5738-9-robh@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > Enable building the vexpress-osc clock driver as a module. > > Cc: Linus Walleij > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/clk/versatile/Kconfig | 4 ++-- > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index 5bdd5c98990b..9de2396dcf9b 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -15,8 +15,8 @@ config CLK_SP810 > of the ARM SP810 System Controller cell. > > config CLK_VEXPRESS_OSC > - bool "Clock driver for Versatile Express OSC clock generators" > - depends on VEXPRESS_CONFIG || COMPILE_TEST > + tristate "Clock driver for Versatile Express OSC clock generators" > + depends on VEXPRESS_CONFIG Looks good to me with the exception of COMPILE_TEST appearing in patch 5 and disappearing here. Which one should be the one to survive? Best regards, Liviu > default y if ARCH_VEXPRESS > ---help--- > Simple regmap-based driver driving clock generators on Versatile > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > { .compatible = "arm,vexpress-osc", }, > {} > }; > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > static struct platform_driver vexpress_osc_driver = { > .driver = { > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > }, > .probe = vexpress_osc_probe, > }; > - > -static int __init vexpress_osc_init(void) > -{ > - return platform_driver_register(&vexpress_osc_driver); > -} > -core_initcall(vexpress_osc_init); > +module_platform_driver(vexpress_osc_driver); > +MODULE_LICENSE("GPL v2"); > -- > 2.20.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯