From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 063C3C5518A for ; Wed, 22 Apr 2020 12:04:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E34D420781 for ; Wed, 22 Apr 2020 12:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbgDVMEj (ORCPT ); Wed, 22 Apr 2020 08:04:39 -0400 Received: from foss.arm.com ([217.140.110.172]:48552 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbgDVMEj (ORCPT ); Wed, 22 Apr 2020 08:04:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B20331B; Wed, 22 Apr 2020 05:04:38 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 606A53F6CF; Wed, 22 Apr 2020 05:04:38 -0700 (PDT) Received: by e110455-lin.cambridge.arm.com (Postfix, from userid 1000) id 048DD682F37; Wed, 22 Apr 2020 13:04:37 +0100 (BST) Date: Wed, 22 Apr 2020 13:04:36 +0100 From: Liviu Dudau To: Rob Herring Cc: Linus Walleij , Lorenzo Pieralisi , Sudeep Holla , Arnd Bergmann , Catalin Marinas , Greg Kroah-Hartman , Lee Jones , Sebastian Reichel , Stephen Boyd , Will Deacon , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 16/17] bus: vexpress-config: Support building as module Message-ID: <20200422120436.GA364558@e110455-lin.cambridge.arm.com> References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-17-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200419170810.5738-17-robh@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Apr 19, 2020 at 12:08:09PM -0500, Rob Herring wrote: > Enable building vexpress-config driver as a module. > > Cc: Liviu Dudau Acked-by: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Linus Walleij > Cc: Greg Kroah-Hartman > Signed-off-by: Rob Herring > --- > drivers/bus/Kconfig | 2 +- > drivers/bus/vexpress-config.c | 10 ++++------ > 2 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index 6d4e4497b59b..c16268c53831 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -183,7 +183,7 @@ config UNIPHIER_SYSTEM_BUS > needed to use on-board devices connected to UniPhier SoCs. > > config VEXPRESS_CONFIG > - bool "Versatile Express configuration bus" > + tristate "Versatile Express configuration bus" > default y if ARCH_VEXPRESS > depends on ARM || ARM64 > depends on OF > diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c > index caa35a4cb34d..a58ac0c8e282 100644 > --- a/drivers/bus/vexpress-config.c > +++ b/drivers/bus/vexpress-config.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -407,15 +408,12 @@ static const struct platform_device_id vexpress_syscfg_id_table[] = { > { "vexpress-syscfg", }, > {}, > }; > +MODULE_DEVICE_TABLE(platform, vexpress_syscfg_id_table); > > static struct platform_driver vexpress_syscfg_driver = { > .driver.name = "vexpress-syscfg", > .id_table = vexpress_syscfg_id_table, > .probe = vexpress_syscfg_probe, > }; > - > -static int __init vexpress_syscfg_init(void) > -{ > - return platform_driver_register(&vexpress_syscfg_driver); > -} > -core_initcall(vexpress_syscfg_init); > +module_platform_driver(vexpress_syscfg_driver); > +MODULE_LICENSE("GPL v2"); > -- > 2.20.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯