From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610CAC55185 for ; Wed, 22 Apr 2020 21:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 481C020787 for ; Wed, 22 Apr 2020 21:08:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726161AbgDVVIK (ORCPT ); Wed, 22 Apr 2020 17:08:10 -0400 Received: from foss.arm.com ([217.140.110.172]:54924 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgDVVIK (ORCPT ); Wed, 22 Apr 2020 17:08:10 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA8FC31B; Wed, 22 Apr 2020 14:08:09 -0700 (PDT) Received: from bogus (unknown [10.37.12.118]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 009BD3F68F; Wed, 22 Apr 2020 14:08:05 -0700 (PDT) Date: Wed, 22 Apr 2020 22:08:02 +0100 From: Sudeep Holla To: Rob Herring Cc: Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Arnd Bergmann , Catalin Marinas , Greg Kroah-Hartman , Lee Jones , Sebastian Reichel , Stephen Boyd , Will Deacon , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Michael Turquette Subject: Re: [PATCH 08/17] clk: vexpress-osc: Support building as a module Message-ID: <20200422210802.GH25585@bogus> References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-9-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200419170810.5738-9-robh@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, Apr 19, 2020 at 12:08:01PM -0500, Rob Herring wrote: > Enable building the vexpress-osc clock driver as a module. > > Cc: Linus Walleij > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Lorenzo Pieralisi > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: linux-clk@vger.kernel.org > Signed-off-by: Rob Herring > --- > drivers/clk/versatile/Kconfig | 4 ++-- > drivers/clk/versatile/clk-vexpress-osc.c | 10 ++++------ > 2 files changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/versatile/Kconfig b/drivers/clk/versatile/Kconfig > index 5bdd5c98990b..9de2396dcf9b 100644 > --- a/drivers/clk/versatile/Kconfig > +++ b/drivers/clk/versatile/Kconfig > @@ -15,8 +15,8 @@ config CLK_SP810 > of the ARM SP810 System Controller cell. > > config CLK_VEXPRESS_OSC > - bool "Clock driver for Versatile Express OSC clock generators" > - depends on VEXPRESS_CONFIG || COMPILE_TEST > + tristate "Clock driver for Versatile Express OSC clock generators" > + depends on VEXPRESS_CONFIG > default y if ARCH_VEXPRESS > ---help--- > Simple regmap-based driver driving clock generators on Versatile > diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c > index 5bb1d5a714d0..b2b32fa2d7c3 100644 > --- a/drivers/clk/versatile/clk-vexpress-osc.c > +++ b/drivers/clk/versatile/clk-vexpress-osc.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -108,6 +109,7 @@ static const struct of_device_id vexpress_osc_of_match[] = { > { .compatible = "arm,vexpress-osc", }, > {} > }; > +MODULE_DEVICE_TABLE(of, vexpress_osc_of_match); > > static struct platform_driver vexpress_osc_driver = { > .driver = { > @@ -116,9 +118,5 @@ static struct platform_driver vexpress_osc_driver = { > }, > .probe = vexpress_osc_probe, > }; > - > -static int __init vexpress_osc_init(void) > -{ > - return platform_driver_register(&vexpress_osc_driver); > -} > -core_initcall(vexpress_osc_init); > +module_platform_driver(vexpress_osc_driver); I am not 100% sure of this. This might break the boot on CA9 and TC2 at-least. There are loads of MB peripherals that need this. This will break the boot. We need to check if all the dependent modules are also at module_initcall level and if they deal with deferred probe correctly. Lot of them are legacy and may happen to be working by carefully initcall level adjustments. I will take a look at it again. I must be able to run and check on TC2 though I seem to have removed the network cable on my TC2 or office n/w is acting crazy. I will check tomorrow again or run w/o network. -- Regards, Sudeep