From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14638C2BA1A for ; Fri, 24 Apr 2020 10:53:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E984620776 for ; Fri, 24 Apr 2020 10:53:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TqnzzbkL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726888AbgDXKxY (ORCPT ); Fri, 24 Apr 2020 06:53:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726813AbgDXKxX (ORCPT ); Fri, 24 Apr 2020 06:53:23 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9B3FC09B045 for ; Fri, 24 Apr 2020 03:53:22 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id d15so8616784wrx.3 for ; Fri, 24 Apr 2020 03:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=ANVFxj0a3PZxuvcR/cQpqDlmHqLVaxnBkwvzY2D+yRQ=; b=TqnzzbkLwgVbmsD15PJo6vPGbNOmNr2/mJjPgL9eevI2ZbgbaLKHqzcjjpusU51Doh NVKcjMg+bWBhUhNbQDdkbqj9ERt0ChWSN01vAzVDSi9CmtdIQtsX8VUHEB3/jNNRSerX y9U+/g8CZ27zw3gjVVpl4mV24Jl5Fr5r/scKO/zgNbjmn48lfTIykG9/YnSj4IzlpQ7x 9sCMoDp9Q+frjZdGucx9E0GLUTjBwivWtbkXOEqoXAzz/EXNwZawwuny5QWFYB/4wCko MgQOaXyD5AxOimhaN8V4FFfg8BCImvzBgwiESTze/+9yXbeRgPdupE3wfoBu6Sl2sbkX PAyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ANVFxj0a3PZxuvcR/cQpqDlmHqLVaxnBkwvzY2D+yRQ=; b=hnXA44OA56K69uHQ21VTv6BsiUz1JeSbJbrthjxiYEYqcllt4uq3O0cabP74HxjCXo Bt+qh414dvVgoJHcgYq6j0iz1q+4kIVHLUFLCJXGrdGCLGJL52po15vqOltHWSKWm3YD 5BShYiW7MBcDd+F3Kg7OP+SMuv+1qMy8LEA12t76RM5rGQRwoKh2W0i0NVkTLSyffxnb B6zFI71H/sryrOjWwlEwBrAI4LDNJ2/0GqYSkrGhWV4/e89yeaIu5t9HIqDc1FZnbv71 QIJ8Kr2DtQ0yqBtjbhF1L71TUzfi2ypxG661iU23C3XAmXie5iqdP4Xj1wEkHjXbGp1r BpxA== X-Gm-Message-State: AGi0PuZSJiwCjnPJSExJV0/gDWsAzCyfPd7iphaBczU8TiLU7FWDldxk fSqRMH5tdnvfxQjZfieP95xA4qNFykU= X-Google-Smtp-Source: APiQypKP9clOM1Dthyy7Ek8Ij90zL+Giy22gsKlvN3INV/Bf1kE9Y4mK9kb1o6kuHIq3Nyvws+waXA== X-Received: by 2002:adf:cd12:: with SMTP id w18mr10512940wrm.177.1587725601416; Fri, 24 Apr 2020 03:53:21 -0700 (PDT) Received: from dell ([2.31.163.63]) by smtp.gmail.com with ESMTPSA id c25sm2218532wmb.44.2020.04.24.03.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2020 03:53:20 -0700 (PDT) Date: Fri, 24 Apr 2020 11:53:19 +0100 From: Lee Jones To: saravanan sekar Cc: andy.shevchenko@gmail.com, robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger Message-ID: <20200424105319.GD8414@dell> References: <20200415162030.16414-1-sravanhome@gmail.com> <20200415162030.16414-3-sravanhome@gmail.com> <20200424071822.GM3612@dell> <8ff17d07-8030-fcfe-8d8a-3011e4077778@gmail.com> <20200424093720.GA3542@dell> <864eb6ad-a605-c0a0-c3e7-23c0c70f5ede@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <864eb6ad-a605-c0a0-c3e7-23c0c70f5ede@gmail.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Fri, 24 Apr 2020, saravanan sekar wrote: > Hi Lee, > > On 24/04/20 11:37 am, Lee Jones wrote: > > On Fri, 24 Apr 2020, saravanan sekar wrote: > > > > > Hi Lee, > > > > > > On 24/04/20 9:18 am, Lee Jones wrote: > > > > On Wed, 15 Apr 2020, Saravanan Sekar wrote: > > > > > > > > > mp2629 is a highly-integrated switching-mode battery charge management > > > > > device for single-cell Li-ion or Li-polymer battery. > > > > > > > > > > Add MFD core enables chip access for ADC driver for battery readings, > > > > > and a power supply battery-charger driver > > > > > > > > > > Signed-off-by: Saravanan Sekar > > > > > --- > > > > > drivers/mfd/Kconfig | 9 ++++ > > > > > drivers/mfd/Makefile | 2 + > > > > > drivers/mfd/mp2629.c | 86 ++++++++++++++++++++++++++++++++++++++ > > > > > include/linux/mfd/mp2629.h | 19 +++++++++ > > > > > 4 files changed, 116 insertions(+) > > > > > create mode 100644 drivers/mfd/mp2629.c > > > > > create mode 100644 include/linux/mfd/mp2629.h > > > > How is this driver registered? > > > > > > > > Looks like it has device tree support. Is there another way? > > > Yes, only using device tree > > Then how about using 'simple-mfd' and 'syscon'? > > > > Then you can omit this driver completely. > > The exception is to support for non device tree platform as well, but I have > tested only for ARM device tree platform. Is that a reality though? How else do you see this realistically being registered? > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > > index 3c547ed575e6..85be799795aa 100644 > > > > > --- a/drivers/mfd/Kconfig > > > > > +++ b/drivers/mfd/Kconfig > > > > > @@ -434,6 +434,15 @@ config MFD_MC13XXX_I2C > > > > > help > > > > > Select this if your MC13xxx is connected via an I2C bus. > > > > > +config MFD_MP2629 > > > > > + tristate "Monolithic power system MP2629 ADC and Battery charger" > > > > > + depends on I2C > > > > > + select REGMAP_I2C > > > > > + help > > > > > + Select this option to enable support for monolithic power system > > > > > + battery charger. This provides ADC, thermal, battery charger power > > > > > + management functions on the systems. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog