From: Georgi Djakov <georgi.djakov@linaro.org>
To: vireshk@kernel.org, nm@ti.com, sboyd@kernel.org,
robh+dt@kernel.org, rjw@rjwysocki.net, saravanak@google.com,
sibis@codeaurora.org
Cc: rnayak@codeaurora.org, bjorn.andersson@linaro.org,
vincent.guittot@linaro.org, jcrouse@codeaurora.org,
evgreen@chromium.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
georgi.djakov@linaro.org
Subject: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes
Date: Fri, 24 Apr 2020 18:54:03 +0300 [thread overview]
Message-ID: <20200424155404.10746-7-georgi.djakov@linaro.org> (raw)
In-Reply-To: <20200424155404.10746-1-georgi.djakov@linaro.org>
If the OPP bandwidth values are populated, we want to switch also the
interconnect bandwidth in addition to frequency and voltage.
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
---
v7:
* Addressed review comments from Viresh.
v2: https://lore.kernel.org/r/20190423132823.7915-5-georgi.djakov@linaro.org
drivers/opp/core.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 8e86811eb7b2..66a8ea10f3de 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -808,7 +808,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
unsigned long freq, old_freq, temp_freq;
struct dev_pm_opp *old_opp, *opp;
struct clk *clk;
- int ret;
+ int ret, i;
opp_table = _find_opp_table(dev);
if (IS_ERR(opp_table)) {
@@ -895,6 +895,17 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
dev_err(dev, "Failed to set required opps: %d\n", ret);
}
+ if (!ret && opp_table->paths) {
+ for (i = 0; i < opp_table->path_count; i++) {
+ ret = icc_set_bw(opp_table->paths[i],
+ opp->bandwidth[i].avg,
+ opp->bandwidth[i].peak);
+ if (ret)
+ dev_err(dev, "Failed to set bandwidth[%d]: %d\n",
+ i, ret);
+ }
+ }
+
put_opp:
dev_pm_opp_put(opp);
put_old_opp:
next prev parent reply other threads:[~2020-04-24 15:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 15:53 [PATCH v7 0/7] Introduce OPP bandwidth bindings Georgi Djakov
2020-04-24 15:53 ` [PATCH v7 1/7] dt-bindings: opp: Introduce opp-peak-kBps and opp-avg-kBps bindings Georgi Djakov
2020-04-30 5:09 ` Viresh Kumar
2020-05-04 20:31 ` Sibi Sankar
2020-05-11 21:51 ` Rob Herring
2020-04-24 15:53 ` [PATCH v7 2/7] OPP: Add helpers for reading the binding properties Georgi Djakov
2020-04-24 17:30 ` Matthias Kaehlcke
2020-04-30 5:21 ` Viresh Kumar
2020-05-04 20:40 ` Sibi Sankar
2020-04-24 15:54 ` [PATCH v7 3/7] interconnect: Add of_icc_get_by_index() helper function Georgi Djakov
2020-04-24 18:02 ` Matthias Kaehlcke
2020-05-04 20:58 ` Sibi Sankar
2020-04-24 15:54 ` [PATCH v7 4/7] OPP: Add support for parsing interconnect bandwidth Georgi Djakov
2020-04-24 19:20 ` Matthias Kaehlcke
2020-04-28 16:21 ` Georgi Djakov
2020-04-30 5:28 ` Viresh Kumar
2020-05-04 21:03 ` Sibi Sankar
2020-04-24 15:54 ` [PATCH v7 5/7] OPP: Add sanity checks in _read_opp_key() Georgi Djakov
2020-04-24 19:26 ` Matthias Kaehlcke
2020-05-04 20:47 ` Sibi Sankar
2020-04-24 15:54 ` Georgi Djakov [this message]
2020-04-24 19:36 ` [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes Matthias Kaehlcke
2020-04-24 21:18 ` Saravana Kannan
2020-04-30 6:09 ` Viresh Kumar
2020-04-30 7:35 ` Saravana Kannan
2020-04-30 7:53 ` Viresh Kumar
2020-04-30 16:32 ` Saravana Kannan
2020-05-04 5:00 ` Viresh Kumar
2020-05-04 21:01 ` Saravana Kannan
2020-05-05 3:38 ` Viresh Kumar
2020-05-04 20:54 ` Sibi Sankar
2020-04-24 15:54 ` [PATCH v7 7/7] cpufreq: dt: Add support for interconnect bandwidth scaling Georgi Djakov
2020-04-24 19:41 ` Matthias Kaehlcke
2020-05-04 20:50 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424155404.10746-7-georgi.djakov@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).