linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>
Cc: Kevin Brodsky <Kevin.Brodsky@arm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Lee Jones <lee.jones@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Will Deacon <will@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: [PATCH v2 09/16] mfd: vexpress-sysreg: Drop unused syscon child devices
Date: Wed, 29 Apr 2020 15:58:18 -0500	[thread overview]
Message-ID: <20200429205825.10604-10-robh@kernel.org> (raw)
In-Reply-To: <20200429205825.10604-1-robh@kernel.org>

The "sys_id", "sys_misc" and "sys_procid" devices don't have a user
anywhere in the tree and do nothing more than create a syscon regmap for
a single register or 2. That's an overkill for creating child devices.
Let's just remove them.

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
Note that the other GPIO child devices could probably be removed and
added to the bgpio driver. Unfortunately, the model dts files were
never updated 6 years ago. Not sure if the models really need LEDs...

v2:
 - Add missing commmit message
---
 drivers/mfd/vexpress-sysreg.c | 36 -----------------------------------
 1 file changed, 36 deletions(-)

diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index 0b9cc67706c7..90a4eda2ba2b 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -43,10 +43,6 @@
 
 /* The sysreg block is just a random collection of various functions... */
 
-static struct syscon_platform_data vexpress_sysreg_sys_id_pdata = {
-	.label = "sys_id",
-};
-
 static struct bgpio_pdata vexpress_sysreg_sys_led_pdata = {
 	.label = "sys_led",
 	.base = -1,
@@ -65,24 +61,8 @@ static struct bgpio_pdata vexpress_sysreg_sys_flash_pdata = {
 	.ngpio = 1,
 };
 
-static struct syscon_platform_data vexpress_sysreg_sys_misc_pdata = {
-	.label = "sys_misc",
-};
-
-static struct syscon_platform_data vexpress_sysreg_sys_procid_pdata = {
-	.label = "sys_procid",
-};
-
 static struct mfd_cell vexpress_sysreg_cells[] = {
 	{
-		.name = "syscon",
-		.num_resources = 1,
-		.resources = (struct resource []) {
-			DEFINE_RES_MEM(SYS_ID, 0x4),
-		},
-		.platform_data = &vexpress_sysreg_sys_id_pdata,
-		.pdata_size = sizeof(vexpress_sysreg_sys_id_pdata),
-	}, {
 		.name = "basic-mmio-gpio",
 		.of_compatible = "arm,vexpress-sysreg,sys_led",
 		.num_resources = 1,
@@ -109,22 +89,6 @@ static struct mfd_cell vexpress_sysreg_cells[] = {
 		},
 		.platform_data = &vexpress_sysreg_sys_flash_pdata,
 		.pdata_size = sizeof(vexpress_sysreg_sys_flash_pdata),
-	}, {
-		.name = "syscon",
-		.num_resources = 1,
-		.resources = (struct resource []) {
-			DEFINE_RES_MEM(SYS_MISC, 0x4),
-		},
-		.platform_data = &vexpress_sysreg_sys_misc_pdata,
-		.pdata_size = sizeof(vexpress_sysreg_sys_misc_pdata),
-	}, {
-		.name = "syscon",
-		.num_resources = 1,
-		.resources = (struct resource []) {
-			DEFINE_RES_MEM(SYS_PROCID0, 0x8),
-		},
-		.platform_data = &vexpress_sysreg_sys_procid_pdata,
-		.pdata_size = sizeof(vexpress_sysreg_sys_procid_pdata),
 	}, {
 		.name = "vexpress-syscfg",
 		.num_resources = 1,
-- 
2.20.1


  parent reply	other threads:[~2020-04-29 20:58 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 20:58 [PATCH v2 00/17] Modularizing Versatile Express Rob Herring
2020-04-29 20:58 ` [PATCH v2 01/16] ARM: vexpress: Move vexpress_flags_set() into arch code Rob Herring
2020-05-04  8:56   ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 02/16] arm64: vexpress: Don't select CONFIG_POWER_RESET_VEXPRESS Rob Herring
2020-04-29 20:58 ` [PATCH v2 03/16] amba: Retry adding deferred devices at late_initcall Rob Herring
2020-04-29 20:58 ` [PATCH v2 04/16] clk: versatile: Rework kconfig structure Rob Herring
2020-05-01 16:26   ` Sudeep Holla
2020-05-05  6:20   ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 05/16] clk: versatile: Only enable SP810 on 32-bit by default Rob Herring
2020-05-01 16:32   ` Sudeep Holla
2020-05-05  6:20   ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 06/16] clk: vexpress-osc: Use the devres clock API variants Rob Herring
2020-04-29 20:58 ` [PATCH v2 07/16] clk: vexpress-osc: Support building as a module Rob Herring
2020-05-01 16:36   ` Sudeep Holla
2020-05-05  6:21   ` Stephen Boyd
2020-04-29 20:58 ` [PATCH v2 08/16] mfd: vexpress-sysreg: Drop selecting CONFIG_CLKSRC_MMIO Rob Herring
2020-05-01 16:37   ` Sudeep Holla
2020-05-04  8:55   ` Lee Jones
2020-04-29 20:58 ` Rob Herring [this message]
2020-05-01 16:50   ` [PATCH v2 09/16] mfd: vexpress-sysreg: Drop unused syscon child devices Sudeep Holla
2020-05-04  8:41   ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 10/16] mfd: vexpress-sysreg: Use devres API variants Rob Herring
2020-05-01 16:56   ` Sudeep Holla
2020-05-04  8:41   ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 11/16] mfd: vexpress-sysreg: Support building as a module Rob Herring
2020-05-01 16:58   ` Sudeep Holla
2020-05-04  8:40   ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 12/16] bus: vexpress-config: Merge vexpress-syscfg into vexpress-config Rob Herring
2020-05-01 17:02   ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 13/16] bus: vexpress-config: simplify config bus probing Rob Herring
2020-05-01 17:10   ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 14/16] vexpress: Move setting master site to vexpress-config bus Rob Herring
2020-05-01 17:18   ` Sudeep Holla
2020-05-04  8:26   ` Lee Jones
2020-04-29 20:58 ` [PATCH v2 15/16] bus: vexpress-config: Support building as module Rob Herring
2020-05-01 16:58   ` Sudeep Holla
2020-04-29 20:58 ` [PATCH v2 16/16] ARM: vexpress: Don't select VEXPRESS_CONFIG Rob Herring
2020-05-01 16:55   ` Sudeep Holla
2020-04-29 22:11 ` [PATCH v2 00/17] Modularizing Versatile Express Sebastian Reichel
2020-05-01 17:20 ` Sudeep Holla
2020-06-17 15:08 ` Daniel Thompson
2020-07-08 16:39   ` Rob Herring
2020-07-09 11:33     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429205825.10604-10-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Kevin.Brodsky@arm.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=sboyd@kernel.org \
    --cc=sre@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).