From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCAFC2D0FD for ; Wed, 13 May 2020 10:02:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB67E20575 for ; Wed, 13 May 2020 10:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589364138; bh=4teFK8yAPQaudrvOkMtxHTK4dS9GB4B0H+iGbpSKcXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=keTCEuu2xQd5rUjxln0TiR1YoF8DVdsFUomR2dyhX2q2PHt6/1ECYQ9ZRYDAnVrEG zvaalWGL6WTZQpNA1RHkUuGUiH90/1tGCOBZtkriOw80sgoRwPxPMgIPjFt/i+dy/H R6/8F/54YFiEwiQfIqi86xohO8vtFDpp7X69NEw8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387493AbgEMKCR (ORCPT ); Wed, 13 May 2020 06:02:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:37508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387474AbgEMKCQ (ORCPT ); Wed, 13 May 2020 06:02:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7271E206B8; Wed, 13 May 2020 10:02:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589364135; bh=4teFK8yAPQaudrvOkMtxHTK4dS9GB4B0H+iGbpSKcXE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jFr2qo1yZ16htVmXSelC+yVYkaYSuZGpz2WvaV0I1WIqo2vLRXY0NIN69zSxbgCsY m/OG5MeRhHsU6xUhe1+UCHt7S1Wtpt0bXwueF+Kc+j6iClm8Ab/jY6w/KXMeO4pXfT ABUKgSTqKWPwHMSSJ9d9NIJf1cXL3NFa109Vn960= Date: Wed, 13 May 2020 12:02:13 +0200 From: Greg KH To: Quentin Perret Cc: "Rafael J. Wysocki" , Peter Zijlstra , Linux Kernel Mailing List , Linux PM , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , "H. Peter Anvin" , Sudeep Holla , Viresh Kumar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Benjamin Segall , Mel Gorman , "Luis R. Rodriguez" , Kees Cook , Iurii Zaikin , Frederic Weisbecker , Todd Kjos , "Cc: Android Kernel" Subject: Re: [PATCH 00/14] Modularize schedutil Message-ID: <20200513100213.GA868852@kroah.com> References: <20200512092102.GA16151@google.com> <20200512135813.GA101124@google.com> <20200512151120.GB101124@google.com> <20200512162630.GC101124@google.com> <20200513094117.GB225140@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513094117.GB225140@google.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Wed, May 13, 2020 at 10:41:17AM +0100, Quentin Perret wrote: > Hi Rafael, > > On Tuesday 12 May 2020 at 19:30:52 (+0200), Rafael J. Wysocki wrote: > > I don't see any technical reason for making schedutil modular in the > > context of GKI other than to make the GKI image smaller, but I don't > > expect that to be significant enough. > > The fact that we can make the image smaller, and we give vendors one > less reason to not-want GKI _is_ desirable IMO. > > $ size vmlinux.* > text data bss dec hex filename > 19225963 9601976 491084 29319023 1bf5f6f vmlinux.after > 19230599 9603236 491084 29324919 1bf7677 vmlinux.before > > ^ that's with the series applied. 'before' means sugov is =y, and > 'after' is sugov =m. So modularizing saves just over 4K on text, and a > bit of data too. Is it significant? Maybe not. But it's quite likely > that those who don't use schedutil will find any unnecessary byte to be > one too many. It's not significant at all, just always build it in, no one will notice it, it's just a page or two. Serial port drivers are way bigger :) thanks, greg k-h