From: Lee Jones <lee.jones@linaro.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-amlogic@lists.infradead.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: add support for the Khadas System control Microcontroller
Date: Tue, 2 Jun 2020 09:33:11 +0100 [thread overview]
Message-ID: <20200602083311.GD3714@dell> (raw)
In-Reply-To: <8837fa43-bf46-fdd1-472e-e5f0159dab2c@baylibre.com>
On Tue, 02 Jun 2020, Neil Armstrong wrote:
> On 20/05/2020 11:01, Lee Jones wrote:
> > On Tue, 12 May 2020, Neil Armstrong wrote:
> >
> >> This Microcontroller is present on the Khadas VIM1, VIM2, VIM3 and Edge
> >> boards.
> >>
> >> It has multiple boot control features like password check, power-on
> >> options, power-off control and system FAN control on recent boards.
> >>
> >> This implements a very basic MFD driver with the fan control and User
> >> NVMEM cells.
> >>
> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> >> ---
> >> drivers/mfd/Kconfig | 14 ++++
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/khadas-mcu.c | 143 +++++++++++++++++++++++++++++++++
> >> include/linux/mfd/khadas-mcu.h | 91 +++++++++++++++++++++
> >> 4 files changed, 249 insertions(+)
> >> create mode 100644 drivers/mfd/khadas-mcu.c
> >> create mode 100644 include/linux/mfd/khadas-mcu.h
> >>
> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> >> index 0a59249198d3..b95091397052 100644
> >> --- a/drivers/mfd/Kconfig
> >> +++ b/drivers/mfd/Kconfig
> >> @@ -2003,6 +2003,20 @@ config MFD_WCD934X
> >> This driver provides common support WCD934x audio codec and its
> >> associated Pin Controller, Soundwire Controller and Audio codec.
> >>
> >> +config MFD_KHADAS_MCU
> >> + tristate "Support for Khadas System control Microcontroller"
> >> + depends on I2C
> >> + depends on OF || COMPILE_TEST
> >> + select MFD_CORE
> >> + select REGMAP_I2C
> >> + help
> >> + Support for the Khadas System control Microcontroller interface present
> >> + on their VIM and Edge boards.
> >> +
> >> + This driver provides common support for accessing the device,
> >> + additional drivers must be enabled in order to use the functionality
> >> + of the device.
> >
> > It would be good to describe the device here.
>
> Ok
If you agree with all review comments, there really is no need to
reply. It's a waste of your time and anyone else who cares enough to
search through looking for replies (as I just did).
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-06-02 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:26 [PATCH v2 0/6] mfd: Add support for Khadas Microcontroller Neil Armstrong
2020-05-12 13:26 ` [PATCH v2 1/6] dt-bindings: mfd: add Khadas Microcontroller bindings Neil Armstrong
2020-05-15 6:42 ` Amit Kucheria
2020-05-12 13:26 ` [PATCH v2 2/6] mfd: add support for the Khadas System control Microcontroller Neil Armstrong
2020-05-20 9:01 ` Lee Jones
2020-06-02 8:26 ` Neil Armstrong
2020-06-02 8:33 ` Lee Jones [this message]
2020-05-12 13:26 ` [PATCH v2 3/6] thermal: add support for the MCU controlled FAN on Khadas boards Neil Armstrong
2020-05-15 6:41 ` Amit Kucheria
2020-05-15 8:05 ` Neil Armstrong
2020-06-02 8:26 ` Neil Armstrong
2020-05-12 13:26 ` [PATCH v2 4/6] nvmem: add support for the Khadas MCU Programmable User Memory Neil Armstrong
2020-05-13 10:34 ` Srinivas Kandagatla
2020-05-13 12:33 ` Neil Armstrong
2020-05-15 10:55 ` Srinivas Kandagatla
2020-06-02 8:29 ` Neil Armstrong
2020-05-12 13:26 ` [PATCH v2 5/6] MAINTAINERS: add myself as maintainer for Khadas MCU drivers Neil Armstrong
2020-05-12 13:26 ` [PATCH v2 6/6] arm64: dts: meson-khadas-vim3: add Khadas MCU nodes Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602083311.GD3714@dell \
--to=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).