linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Christopherson <sean.j.christopherson@intel.com>
To: kernel test robot <lkp@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Pavel Machek <pavel@ucw.cz>,
	kbuild-all@lists.01.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	Brad Campbell <lists2009@fnarfbargle.com>
Subject: Re: [PATCH] x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup
Date: Sun, 7 Jun 2020 09:34:28 -0700	[thread overview]
Message-ID: <20200607163428.GB24576@linux.intel.com> (raw)
In-Reply-To: <202006060421.fTpTXYbe%lkp@intel.com>

On Sat, Jun 06, 2020 at 05:08:38AM +0800, kernel test robot wrote:
 arch/x86/kernel/cpu/centaur.c: In function 'init_centaur':
> >> arch/x86/kernel/cpu/centaur.c:219:2: error: implicit declaration of function 'init_ia32_feat_ctl' [-Werror=implicit-function-declaration]
> 219 |  init_ia32_feat_ctl(c);
> |  ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> --
> arch/x86/kernel/cpu/zhaoxin.c: In function 'init_zhaoxin':
> >> arch/x86/kernel/cpu/zhaoxin.c:110:2: error: implicit declaration of function 'init_ia32_feat_ctl' [-Werror=implicit-function-declaration]
> 110 |  init_ia32_feat_ctl(c);
> |  ^~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors

Blech, zhaoxin.c an centaur.c don't include asm/cpu.h, and I (obviously)
don't have them enabled in my configs.  I'll wait a day or two more before
sending v2.

diff --git a/arch/x86/kernel/cpu/centaur.c b/arch/x86/kernel/cpu/centaur.c
index 426792565d86..c5cf336e5077 100644
--- a/arch/x86/kernel/cpu/centaur.c
+++ b/arch/x86/kernel/cpu/centaur.c
@@ -3,6 +3,7 @@
 #include <linux/sched.h>
 #include <linux/sched/clock.h>

+#include <asm/cpu.h>
 #include <asm/cpufeature.h>
 #include <asm/e820/api.h>
 #include <asm/mtrr.h>
diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
index df1358ba622b..05fa4ef63490 100644
--- a/arch/x86/kernel/cpu/zhaoxin.c
+++ b/arch/x86/kernel/cpu/zhaoxin.c
@@ -2,6 +2,7 @@
 #include <linux/sched.h>
 #include <linux/sched/clock.h>

+#include <asm/cpu.h>
 #include <asm/cpufeature.h>

 #include "cpu.h"


  reply	other threads:[~2020-06-07 16:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 20:07 [PATCH] x86/cpu: Reinitialize IA32_FEAT_CTL MSR on BSP during wakeup Sean Christopherson
2020-06-05 21:08 ` kernel test robot
2020-06-07 16:34   ` Sean Christopherson [this message]
2020-06-08 13:20     ` Brad Campbell
2020-06-08 10:12 ` Liam Merwick
2020-06-08 17:29   ` Sean Christopherson
2020-06-15 12:15     ` Borislav Petkov
2020-06-08 14:24 ` mlevitsk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200607163428.GB24576@linux.intel.com \
    --to=sean.j.christopherson@intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lists2009@fnarfbargle.com \
    --cc=lkp@intel.com \
    --cc=mingo@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).