From: Matthias Kaehlcke <mka@chromium.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: viresh.kumar@linaro.org, sboyd@kernel.org,
georgi.djakov@linaro.org, saravanak@google.com, nm@ti.com,
bjorn.andersson@linaro.org, agross@kernel.org, rjw@rjwysocki.net,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, dianders@chromium.org,
vincent.guittot@linaro.org, amit.kucheria@linaro.org,
lukasz.luba@arm.com, sudeep.holla@arm.com,
smasetty@codeaurora.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change
Date: Tue, 16 Jun 2020 15:11:57 -0700 [thread overview]
Message-ID: <20200616221157.GA4525@google.com> (raw)
In-Reply-To: <e21f85d64d72ec637c10dae93e8323bb@codeaurora.org>
Hi Sibi,
after doing the review I noticed that Viresh replied on the cover letter
that he picked the series up for v5.9, so I'm not sure if it makes sense
to send a v7.
On Wed, Jun 17, 2020 at 02:35:00AM +0530, Sibi Sankar wrote:
> > > @@ -112,7 +178,7 @@ static int qcom_cpufreq_hw_read_lut(struct
> > > device *cpu_dev,
> > >
> > > if (freq != prev_freq && core_count != LUT_TURBO_IND) {
> > > table[i].frequency = freq;
> > > - dev_pm_opp_add(cpu_dev, freq * 1000, volt);
> > > + qcom_cpufreq_update_opp(cpu_dev, freq, volt);
> >
> > This is the cross-validation mentioned above, right? Shouldn't it
> > include
> > a check of the return value?
>
> Yes, this is the cross-validation step,
> we adjust the voltage if opp-tables are
> present/added successfully and enable
> them, else we would just do a add opp.
> We don't want to exit early on a single
> opp failure. We will error out a bit
> later if the opp-count ends up to be
> zero.
At least an error/warning message would seem convenient when adjusting/adding
an OPP fails, otherwise you would only notice by looking at the sysfs
attributes (if you'd even spot a single/few OPPs to be missing).
next prev parent reply other threads:[~2020-06-16 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 21:33 [PATCH v6 0/5] DDR/L3 Scaling support on SDM845 and SC7180 SoCs Sibi Sankar
2020-06-05 21:33 ` [PATCH v6 1/5] cpufreq: blacklist SDM845 in cpufreq-dt-platdev Sibi Sankar
2020-06-05 21:33 ` [PATCH v6 2/5] cpufreq: blacklist SC7180 " Sibi Sankar
2020-06-05 21:33 ` [PATCH v6 3/5] OPP: Add and export helper to set bandwidth Sibi Sankar
2020-06-15 16:58 ` Matthias Kaehlcke
2020-06-05 21:33 ` [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change Sibi Sankar
2020-06-15 17:25 ` Matthias Kaehlcke
2020-06-16 21:05 ` Sibi Sankar
2020-06-16 22:11 ` Matthias Kaehlcke [this message]
2020-06-17 4:52 ` Viresh Kumar
2020-06-17 16:43 ` Sibi Sankar
2020-06-18 17:05 ` Matthias Kaehlcke
2020-06-05 21:33 ` [PATCH v6 5/5] cpufreq: qcom: Disable fast switch when scaling DDR/L3 Sibi Sankar
2020-06-15 17:32 ` Matthias Kaehlcke
2020-06-08 10:27 ` [PATCH v6 0/5] DDR/L3 Scaling support on SDM845 and SC7180 SoCs Viresh Kumar
-- strict thread matches above, loose matches on Subject: below --
2020-06-22 8:16 Sibi Sankar
2020-06-22 8:16 ` [PATCH v6 4/5] cpufreq: qcom: Update the bandwidth levels on frequency change Sibi Sankar
2020-06-22 15:58 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616221157.GA4525@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=smasetty@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).