Re: [PATCH 0/4] Restore big.LITTLE cpuidle driver for Exynos

Anand Moon
2020-06-16T20:58:13Z

Hi Marek,

On Tue, 16 Jun 2020 at 13:44, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> The ARM big.LITTLE cpuidle driver has been enabled and tested on Samsung
> Exynos 5420/5800 based Peach Pit/Pi Chromebooks and in fact it worked
> only on those boards.
>
> However, support for it was broken by the commit 833b5794e330 ("ARM:
> EXYNOS: reset Little cores when cpu is up") and then never enabled in the
> exynos_defconfig. This patchset provides the needed fix to the common
> code and restores support for it. Thanks to Lukasz Luba who motivated me
> to take a look into this issue.
>
Thanks for this updates.

But I feel some DTS changes are missing for example
d2e5c871ed8a drivers: cpuidle: initialize big.LITTLE driver through DT

But I feel that this feature is not working as desired since
still some missing code changes for cluster idle states are missing.
like clock PWR_CTR and PWR_CTRL2.

-Anand

> Best regards
> Marek Szyprowski
> Samsung R&D Institute Poland
>
>
> Patch summary:
>
> Marek Szyprowski (4):
> ARM: exynos: Apply little core workaround only under secure firmware
> cpuidle: big.LITTLE: enable driver only on Peach-Pit/Pi Chromebooks
> ARM: exynos_defconfig: Enable big.LITTLE cpuidle driver
> ARM: multi_v7_defconfig: Enable big.LITTLE cpuidle driver
>
> arch/arm/configs/exynos_defconfig | 1 +
> arch/arm/configs/multi_v7_defconfig | 1 +
> arch/arm/mach-exynos/mcpm-exynos.c | 10 +++++++---
> drivers/cpuidle/cpuidle-big_little.c | 3 +--
> 4 files changed, 10 insertions(+), 5 deletions(-)
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel