From: Mike Tipton <mdtipton@codeaurora.org>
To: georgi.djakov@linaro.org
Cc: bjorn.andersson@linaro.org, agross@kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Tipton <mdtipton@codeaurora.org>
Subject: [PATCH 2/4] interconnect: qcom: Only wait for completion in AMC/WAKE by default
Date: Mon, 22 Jun 2020 21:08:12 -0700 [thread overview]
Message-ID: <20200623040814.23791-3-mdtipton@codeaurora.org> (raw)
In-Reply-To: <20200623040814.23791-1-mdtipton@codeaurora.org>
Change the default TCS wait behavior to only wait for completion in AMC
and WAKE. Waiting isn't necessary in the SLEEP TCS, since votes are only
being removed in this case. Resources can be safely disabled
asynchronously in parallel with the rest of the power collapse sequence.
This reduces the sleep entry latency.
Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
---
drivers/interconnect/qcom/bcm-voter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c
index e9f66f5c8a91..bb83ce7554b7 100644
--- a/drivers/interconnect/qcom/bcm-voter.c
+++ b/drivers/interconnect/qcom/bcm-voter.c
@@ -345,7 +345,7 @@ static int qcom_icc_bcm_voter_probe(struct platform_device *pdev)
voter->np = np;
if (of_property_read_u32(np, "qcom,tcs-wait", &voter->tcs_wait))
- voter->tcs_wait = QCOM_ICC_TAG_ALWAYS;
+ voter->tcs_wait = QCOM_ICC_TAG_ACTIVE_ONLY;
mutex_init(&voter->lock);
INIT_LIST_HEAD(&voter->commit_list);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2020-06-23 4:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 4:08 [PATCH 0/4] interconnect: qcom: Misc bcm-voter changes and fixes Mike Tipton
2020-06-23 4:08 ` [PATCH 1/4] interconnect: qcom: Support bcm-voter-specific TCS wait behavior Mike Tipton
2020-07-02 9:02 ` Georgi Djakov
2020-07-02 21:01 ` Mike Tipton
2020-06-23 4:08 ` Mike Tipton [this message]
2020-06-23 4:08 ` [PATCH 3/4] interconnect: qcom: Add support for per-BCM scaling factors Mike Tipton
2020-06-23 4:08 ` [PATCH 4/4] interconnect: qcom: Fix small BW votes being truncated to zero Mike Tipton
2020-07-02 11:11 ` Georgi Djakov
2020-07-02 21:02 ` Mike Tipton
2020-07-06 16:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623040814.23791-3-mdtipton@codeaurora.org \
--to=mdtipton@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).