From: Kees Cook <keescook@chromium.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Borislav Petkov <bp@alien8.de>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
rjw@rjwysocki.net, viresh.kumar@linaro.org, lenb@kernel.org,
dsmythies@telus.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org, jic23@cam.ac.uk,
akpm@linux-foundation.org
Subject: Re: [PATCH] lib: Extend kstrtobool() to accept "true"/"false"
Date: Fri, 26 Jun 2020 08:51:50 -0700 [thread overview]
Message-ID: <202006260845.B573D53@keescook> (raw)
In-Reply-To: <20200626104442.GF117543@hirez.programming.kicks-ass.net>
On Fri, Jun 26, 2020 at 12:44:42PM +0200, Peter Zijlstra wrote:
> On Fri, Jun 26, 2020 at 12:22:55PM +0200, Peter Zijlstra wrote:
>
> > > This is too lax - it will be enabled for any !0 value. Please accept
> > > only 0 and 1.
> >
> > kstrtobool() ftw
>
> And looking at that, I find it really strange it does not in fact accept
> "true" / "false", so how about this?
>
> ---
> Subject: lib: Extend kstrtobool() to accept "true"/"false"
>
> Extend the strings recognised by kstrtobool() to cover:
>
> - 1/0
> - y/n
> - yes/no (new)
> - t/f (new)
> - true/false (new)
> - on/off
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
There were some worries about dealing with unterminated strings when I
did the original conversion[1], but I think those all got fixed.
Reviewed-by: Kees Cook <keescook@chromium.org>
[1] https://lore.kernel.org/lkml/CAGXu5jJrFv5Y8Q_i3yFYBDmT0+pO05dS3ijB0gOn-huasxZWmA@mail.gmail.com/
--
Kees Cook
next prev parent reply other threads:[~2020-06-26 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 22:49 [UPDATE][PATCH v3 1/2] cpufreq: intel_pstate: Allow enable/disable energy efficiency Srinivas Pandruvada
2020-06-26 8:49 ` Borislav Petkov
2020-06-26 9:12 ` Srinivas Pandruvada
2020-06-26 10:22 ` Peter Zijlstra
2020-06-26 10:44 ` [PATCH] lib: Extend kstrtobool() to accept "true"/"false" Peter Zijlstra
2020-06-26 11:10 ` Srinivas Pandruvada
2020-06-26 15:49 ` Rafael J. Wysocki
2020-06-26 15:51 ` Kees Cook [this message]
2020-06-29 12:09 ` Pavel Machek
2020-07-01 2:38 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006260845.B573D53@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dsmythies@telus.net \
--cc=hpa@zytor.com \
--cc=jic23@cam.ac.uk \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).