From: Rob Herring <robh@kernel.org>
To: Mike Tipton <mdtipton@codeaurora.org>
Cc: georgi.djakov@linaro.org, bjorn.andersson@linaro.org,
agross@kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: interconnect: Add property to set BCM TCS wait behavior
Date: Fri, 10 Jul 2020 10:31:19 -0600 [thread overview]
Message-ID: <20200710163119.GA2753833@bogus> (raw)
In-Reply-To: <20200710015652.19206-3-mdtipton@codeaurora.org>
On Thu, Jul 09, 2020 at 06:56:48PM -0700, Mike Tipton wrote:
> Add "qcom,tcs-wait" property to set which TCS should wait for completion
> when triggering.
>
> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
> ---
> .../bindings/interconnect/qcom,bcm-voter.yaml | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
> index 5971fc1df08d..f0c3d6b01831 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,bcm-voter.yaml
> @@ -21,6 +21,16 @@ properties:
> enum:
> - qcom,bcm-voter
>
> + qcom,tcs-wait:
> + description: |
> + Optional mask of which TCSs (Triggered Command Sets) wait for completion
> + upon triggering. In most cases, it's necessary to wait in both the AMC
> + and WAKE sets to ensure resources are available before use. If a specific
> + RSC and its use cases can ensure sufficient delay by other means, then
> + this can be overridden to reduce latencies.
I have no idea what any of this means to provide any meaningful comment.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: QCOM_ICC_TAG_ACTIVE_ONLY
Can't use defines here.
> +
> required:
> - compatible
>
> @@ -39,7 +49,10 @@ examples:
> # as defined in Documentation/devicetree/bindings/soc/qcom/rpmh-rsc.txt
> - |
>
> + #include <dt-bindings/interconnect/qcom,icc.h>
> +
> disp_bcm_voter: bcm_voter {
> compatible = "qcom,bcm-voter";
> + qcom,tcs-wait = <QCOM_ICC_TAG_AMC>;
> };
> ...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-07-10 16:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 1:56 [PATCH v2 0/6] interconnect: qcom: Misc bcm-voter changes and fixes Mike Tipton
2020-07-10 1:56 ` [PATCH v2 1/6] dt-bindings: interconnect: Add generic qcom bindings Mike Tipton
2020-07-10 1:56 ` [PATCH v2 2/6] dt-bindings: interconnect: Add property to set BCM TCS wait behavior Mike Tipton
2020-07-10 16:31 ` Rob Herring [this message]
2020-07-18 0:41 ` Mike Tipton
2020-07-10 1:56 ` [PATCH v2 3/6] interconnect: qcom: Support bcm-voter-specific " Mike Tipton
2020-07-10 1:56 ` [PATCH v2 4/6] interconnect: qcom: Only wait for completion in AMC/WAKE by default Mike Tipton
2020-07-10 1:56 ` [PATCH v2 5/6] interconnect: qcom: Add support for per-BCM scaling factors Mike Tipton
2020-07-10 1:56 ` [PATCH v2 6/6] interconnect: qcom: Fix small BW votes being truncated to zero Mike Tipton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710163119.GA2753833@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mdtipton@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).