From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Perry Yuan <Perry.Yuan@dell.com>
Cc: sre@kernel.org, pali@kernel.org, dvhart@infradead.org,
andy@infradead.org, mario.limonciello@dell.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.
Date: Wed, 29 Jul 2020 08:27:56 +0100 [thread overview]
Message-ID: <20200729072756.46skroedpbo3fjyn@srcf.ucam.org> (raw)
In-Reply-To: <20200729065424.12851-1-Perry_Yuan@Dell.com>
On Tue, Jul 28, 2020 at 11:54:24PM -0700, Perry Yuan wrote:
This seems extremely useful, but:
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index bf3b48f022dc..a8adc3b0ca4b 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -334,6 +334,29 @@ Description:
> Access: Read
> Valid values: Represented in microvolts
>
> +What: /sys/class/power_supply/<supply_name>/charge_control_charging_mode
> +Date: March 2020
> +Contact: linux-pm@vger.kernel.org
The values here seem very Dell specific, but this is going into a
generic sysfs path. Really stuff here should be as vendor independent as
possible. If these values don't correspond to a wider industry
specification it probably makes sense to make this something Dell
specific.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2020-07-29 8:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 6:54 [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch Perry Yuan
2020-07-29 7:27 ` Matthew Garrett [this message]
2020-07-29 13:14 ` Limonciello, Mario
2020-07-29 7:32 ` Andy Shevchenko
2020-08-04 6:19 ` Yuan, Perry
2020-08-01 5:07 ` kernel test robot
2020-08-04 5:46 ` Yuan, Perry
2020-08-04 5:53 ` Matthew Garrett
2020-08-04 5:57 ` Yuan, Perry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729072756.46skroedpbo3fjyn@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=Perry.Yuan@dell.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox