From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Viresh Kumar <vireshk@kernel.org>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
mka@chromium.org, sibis@codeaurora.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] opp: Track device's resources configuration status
Date: Mon, 17 Aug 2020 10:35:28 +0530 [thread overview]
Message-ID: <20200817050434.cisjgwo4lxl652fb@vireshk-mac-ubuntu> (raw)
In-Reply-To: <159747859192.33733.13232258434530046392@swboyd.mtv.corp.google.com>
On 15-08-20, 01:03, Stephen Boyd wrote:
> Quoting Viresh Kumar (2020-08-12 21:28:59)
> > The OPP core needs to track if the resources of devices are enabled or
> > configured or not, as it disables the resources when target_freq is set
> > to 0.
> >
> > Handle that with a separate variable to make it easy to maintain.
> >
> > Also note that we will unconditionally call clk_set_rate() in the case
> > where the resources are getting enabled again. This shouldn't have any
> > side effects anyway.
>
> Any reason to want to do that?
To avoid more flags, code paths and simplicity of the code. And this
should normally happen in a corner case as well, like calling
set-rate(0) from suspend and then reinitializing things again in
resume.
> We'll have to grab the prepare lock in
> the clk framework to figure out that there's nothing to do sometimes. If
> anything, a comment may help to indicate that we call clk_set_rate()
> again, but don't expect it to matter much.
Ok.
--
viresh
next prev parent reply other threads:[~2020-08-17 5:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 7:06 [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early Rajendra Nayak
2020-08-10 10:41 ` Sibi Sankar
2020-08-11 17:12 ` Matthias Kaehlcke
2020-08-12 4:30 ` Rajendra Nayak
2020-08-11 21:09 ` Stephen Boyd
2020-08-13 4:29 ` Viresh Kumar
2020-08-16 12:30 ` Rajendra Nayak
2020-08-13 4:28 ` [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier Viresh Kumar
2020-08-13 4:28 ` [PATCH 2/4] opp: Track device's resources configuration status Viresh Kumar
2020-08-15 8:03 ` Stephen Boyd
2020-08-17 5:05 ` Viresh Kumar [this message]
2020-08-13 4:29 ` [PATCH 3/4] opp: Reused enabled flag and remove regulator_enabled Viresh Kumar
2020-08-15 7:55 ` Stephen Boyd
2020-08-20 7:19 ` Viresh Kumar
2020-08-18 7:10 ` Rajendra Nayak
2020-08-13 4:29 ` [PATCH 4/4] opp: Split out _opp_set_rate_zero() Viresh Kumar
2020-08-19 23:56 ` [PATCH V2 1/4] opp: Enable resources again if they were disabled earlier Sasha Levin
2020-08-20 4:58 ` Viresh Kumar
2020-08-26 13:54 ` Sasha Levin
2020-08-27 4:32 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817050434.cisjgwo4lxl652fb@vireshk-mac-ubuntu \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).