From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amitk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: rcar_thermal: Add missing braces to conditional statement
Date: Thu, 20 Aug 2020 08:45:14 +0200 [thread overview]
Message-ID: <20200820064514.GA33898@wyvern> (raw)
In-Reply-To: <20200819092716.3191-1-geert+renesas@glider.be>
Hi Geert,
Thanks for your work.
On 2020-08-19 11:27:16 +0200, Geert Uytterhoeven wrote:
> According to Documentation/process/coding-style.rst, if one branch of a
> conditional statement needs braces, both branches should use braces.
>
> Fixes: bbcf90c0646ac797 ("thermal: Explicitly enable non-changing thermal zone devices")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/thermal/rcar_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
> index 787710bb88fee890..5c2a13bf249ccb87 100644
> --- a/drivers/thermal/rcar_thermal.c
> +++ b/drivers/thermal/rcar_thermal.c
> @@ -546,11 +546,11 @@ static int rcar_thermal_probe(struct platform_device *pdev)
> if (ret < 0)
> goto error_unregister;
>
> - if (chip->use_of_thermal)
> + if (chip->use_of_thermal) {
> priv->zone = devm_thermal_zone_of_sensor_register(
> dev, i, priv,
> &rcar_thermal_zone_of_ops);
> - else {
> + } else {
> priv->zone = thermal_zone_device_register(
> "rcar_thermal",
> 1, 0, priv,
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-08-20 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 9:27 [PATCH] thermal: rcar_thermal: Add missing braces to conditional statement Geert Uytterhoeven
2020-08-20 6:45 ` Niklas Söderlund [this message]
2020-08-24 10:41 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200820064514.GA33898@wyvern \
--to=niklas.soderlund@ragnatech.se \
--cc=amitk@kernel.org \
--cc=andrzej.p@collabora.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=geert+renesas@glider.be \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox