From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BF44C433DF for ; Tue, 25 Aug 2020 18:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45D582076C for ; Tue, 25 Aug 2020 18:20:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726119AbgHYST7 (ORCPT ); Tue, 25 Aug 2020 14:19:59 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:38626 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbgHYST5 (ORCPT ); Tue, 25 Aug 2020 14:19:57 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A673A1C0BB9; Tue, 25 Aug 2020 20:19:55 +0200 (CEST) Date: Tue, 25 Aug 2020 20:19:54 +0200 From: Pavel Machek To: Greg KH Cc: Qiwu Huang , Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Qiwu Huang Subject: Re: [PATCH v8 1/4] power: supply: core: add quick charge type property Message-ID: <20200825181954.GB989@bug> References: <20200814060909.GD1409566@kroah.com> <20200818060707.GB1742213@kroah.com> <20200824074357.GB4133866@kroah.com> <20200824085715.GB402243@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200824085715.GB402243@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi! > > > > If we ported the full driver, we would break the existing driver > > > > structure because we would introduce more Qualcomm code. I think > > > > that's an unreasonable change. > > > > > > That doesn't make much sense. You have a working driver for these apis, > > > just submit it for inclusion, it should never break any existing > > > drivers, otherwise your code wouldn't work either. > > > > We're an Android device, we're working on a Qualcomm based code, and > > from the current code tree, the current code tree is missing the QTI > > Charger code > > I don't know what that means, sorry. Just submit your driver, and any > needed dependencies as well. There's no other way to evaluate this api > addition without that, right? Actually, there's a way to evaluate the API without the driver... if the API is pretty obviously unacceptable. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html