From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6A37C43461 for ; Mon, 7 Sep 2020 09:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5777421473 for ; Mon, 7 Sep 2020 09:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599471115; bh=eP5wyhYnUgbeM5N0DytP9/JFLIDxyhmR9T/dZ+SfNqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=IpLSzZUCr3ypRpnaHftFigGcRm3Ih5SWsjfoljqaGIVfCWo9jaFwzcyVxWacIAWqZ 7vHP0LgWoTYjT5EkHp8GT22K2s0EQncvADakSD58+ff6iPrdK2ylFBLwgSwD/bLmkx ptfd1uDakbLxvNHv+CmJeVTMtOmphg5HgfqvsrLU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728280AbgIGJby (ORCPT ); Mon, 7 Sep 2020 05:31:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:37326 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728093AbgIGJbw (ORCPT ); Mon, 7 Sep 2020 05:31:52 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B382F2075A; Mon, 7 Sep 2020 09:31:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599471111; bh=eP5wyhYnUgbeM5N0DytP9/JFLIDxyhmR9T/dZ+SfNqk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sEK0NXYonD/CE8Y+G5BKcSukg0YWIon0CbRP/xlCInE2m+Qr3KT2RpmvGwPr+lL5V m3uvfqEV/7dBjjypb0/32ltnSaeYuR/vlhwZ4wKr+vpFR+hsm5ySbFS6X7Kl4nAYdB 2aHK6g6YfUHVP12VokidWhyIsCISXd0ZotDABrR4= Date: Mon, 7 Sep 2020 11:32:06 +0200 From: Greg Kroah-Hartman To: John Stultz Cc: lkml , linux-pm@vger.kernel.org, Linus Walleij , Thierry Reding , Mark Brown , Liam Girdwood , Bjorn Andersson , Saravana Kannan , Todd Kjos , Len Brown , Pavel Machek , Ulf Hansson , Kevin Hilman , "Rafael J. Wysocki" , Rob Herring Subject: Re: [RFC][PATCH] pinctrl: Rework driver_deferred_probe_check_state() evaluation since default timeout has changed Message-ID: <20200907093206.GB1393659@kroah.com> References: <20200808043512.106865-1-john.stultz@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200808043512.106865-1-john.stultz@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sat, Aug 08, 2020 at 04:35:12AM +0000, John Stultz wrote: > In commit bec6c0ecb243 ("pinctrl: Remove use of > driver_deferred_probe_check_state_continue()"), we removed the > use of driver_deferred_probe_check_state_continue() which > effectively never returned -ETIMED_OUT, with the > driver_deferred_probe_check_state() function that had been > reworked to properly return ETIMED_OUT when the deferred probe > timeout expired. Along with that change, we set the default > timeout to 30 seconds. > > However, since moving the timeout to 30 seconds caused some > issues for some users with optional dt links, we set the > default timeout back to zero - see commit ce68929f07de ("driver > core: Revert default driver_deferred_probe_timeout value to 0") > > This in essence changed the behavior of the pinctrl's usage > of driver_deferred_probe_check_state(), as it now would return > ETIMED_OUT by default. Thierry reported this caused problems with > resume on tegra platforms. > > Thus this patch tweaks the pinctrl logic so that it behaves as > before. If modules are enabled, we'll only return EPROBE_DEFERRED > while we're missing drivers linked in the DT. > > Cc: linux-pm@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Bjorn Andersson > Cc: Saravana Kannan > Cc: Todd Kjos > Cc: Len Brown > Cc: Pavel Machek > Cc: Ulf Hansson > Cc: Kevin Hilman > Cc: "Rafael J. Wysocki" > Cc: Rob Herring > Fixes: bec6c0ecb243 ("pinctrl: Remove use of driver_deferred_probe_check_state_continue()") > Fixes: ce68929f07de ("driver core: Revert default driver_deferred_probe_timeout value to 0") > Reported-by: Thierry Reding > Signed-off-by: John Stultz > --- > drivers/pinctrl/devicetree.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Greg Kroah-Hartman