From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09282C43461 for ; Mon, 14 Sep 2020 14:04:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C58AB21655 for ; Mon, 14 Sep 2020 14:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="I4ymGcYo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgINOC1 (ORCPT ); Mon, 14 Sep 2020 10:02:27 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:37738 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726783AbgINOAY (ORCPT ); Mon, 14 Sep 2020 10:00:24 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08EDxoon031798; Mon, 14 Sep 2020 14:00:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=x4gHGC7Duk/cI1wHDTEGzvJCX3l7Q0Ymx16IcLniY94=; b=I4ymGcYoyg0CTsKPsVNJkIaadO7jjLKPV73T/z/om8Tx25O6LyxIcLmhA6j5lYAHOlCb gw1l0t0SS4Uf/rjpHOF0oE7o7CjsvtLh29mO5rtRuUzUvWg8A4xSh7aYzzmTR1jYHg6Q vgltM7pldX9t9kiAvQyubronQ7UfJeQpkUvQDuOh+kbLDQhjlzzRYbXO9iDYNquQqA8L cY7tuwcUrXr7jhfWt7e4kFEC91c4KVvQ5AM3TLlVI3c2A4mQ+3XPCoIM0lWWS1WYZuIC MwOLKTNTZlep0a9XuvBPAJRDeRXZeOmDWgKfSJfeCg1kgY34kecqXqPxX7D3WiC/P1BF 5g== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 33gnrqpr47-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Sep 2020 14:00:06 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 08EDtObg147788; Mon, 14 Sep 2020 13:58:06 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 33h881j7qv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 14 Sep 2020 13:58:06 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 08EDw5MC000594; Mon, 14 Sep 2020 13:58:05 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 14 Sep 2020 13:58:04 +0000 Date: Mon, 14 Sep 2020 16:57:57 +0300 From: Dan Carpenter To: Chanwoo Choi Cc: Dmitry Osipenko , MyungJoo Ham , Kyungmin Park , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] PM / devfreq: tegra30: disable clock on error in probe Message-ID: <20200914135757.GA18329@kadam> References: <20200908072557.GC294938@mwanda> <2ceb045a-ebac-58d7-0250-4ea39d711ce8@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ceb045a-ebac-58d7-0250-4ea39d711ce8@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009140114 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9743 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 mlxscore=0 bulkscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 adultscore=0 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009140115 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Sep 14, 2020 at 04:09:02PM +0900, Chanwoo Choi wrote: > Hi, > > On 9/8/20 4:25 PM, Dan Carpenter wrote: > > This error path needs to call clk_disable_unprepare(). > > > > Fixes: 7296443b900e ("PM / devfreq: tegra30: Handle possible round-rate error") > > Signed-off-by: Dan Carpenter > > --- > > --- > > drivers/devfreq/tegra30-devfreq.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > > index e94a27804c20..dedd39de7367 100644 > > --- a/drivers/devfreq/tegra30-devfreq.c > > +++ b/drivers/devfreq/tegra30-devfreq.c > > @@ -836,7 +836,8 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > > rate = clk_round_rate(tegra->emc_clock, ULONG_MAX); > > if (rate < 0) { > > dev_err(&pdev->dev, "Failed to round clock rate: %ld\n", rate); > > - return rate; > > + err = rate; > > + goto disable_clk; > > } > > > > tegra->max_freq = rate / KHZ; > > @@ -897,6 +898,7 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > > dev_pm_opp_remove_all_dynamic(&pdev->dev); > > > > reset_control_reset(tegra->reset); > > +disable_clk: > > clk_disable_unprepare(tegra->clock); > > Is it doesn't need to reset with reset_contrl_reset()? Is that a rhetorical question? I don't know this code very well but it looks like you are right. I'll send a v2. regards, dan carpenter