Re: [PATCH] PM / devfreq: tegra30: disable clock on error in probe

Dmitry Osipenko
2020-09-23T00:23:57Z

21.09.2020 00:37, Dmitry Osipenko пишет:
> 18.09.2020 12:23, Chanwoo Choi пишет:
> ...
>>> Hence if we want to improve the code, I think we can make this change:
>>>
>>> diff --git a/drivers/devfreq/tegra30-devfreq.c
>>> b/drivers/devfreq/tegra30-devfreq.c
>>> index ee274daa57ac..4e3ac23e6850 100644
>>> --- a/drivers/devfreq/tegra30-devfreq.c
>>> +++ b/drivers/devfreq/tegra30-devfreq.c
>>> @@ -891,8 +891,6 @@ static int tegra_devfreq_probe(struct
>>> platform_device *pdev)
>>> return err;
>>> }
>>>
>>> - reset_control_assert(tegra->reset);
>>> -
>>> err = clk_prepare_enable(tegra->clock);
>>> if (err) {
>>> dev_err(&pdev->dev,
>>> @@ -900,7 +898,7 @@ static int tegra_devfreq_probe(struct
>>> platform_device *pdev)
>>> return err;
>>> }
>>>
>>> - reset_control_deassert(tegra->reset);
>>> + reset_control_reset(tegra->reset);
>>>
>>> for (i = 0; i < mc->num_timings; i++) {
>>> /*
>>
>> It looks good to me for improving the readability
>> for everyone who don't know the detailed h/w information.
>
> Okay, I'll make a patch sometime soon.

Chanwoo, I want to clarify that the Dan's v1 patch is still good to me
and should be applied. I'll improve the readability on top of the Dan's
change.