From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E7AEC43461 for ; Tue, 15 Sep 2020 03:17:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D090208DB for ; Tue, 15 Sep 2020 03:17:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BkDvLW7n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726091AbgIODRW (ORCPT ); Mon, 14 Sep 2020 23:17:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbgIODRT (ORCPT ); Mon, 14 Sep 2020 23:17:19 -0400 Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A537FC061788 for ; Mon, 14 Sep 2020 20:17:17 -0700 (PDT) Received: by mail-ot1-x343.google.com with SMTP id m12so1910295otr.0 for ; Mon, 14 Sep 2020 20:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/qWVDCASGrupwV9JyWG9rVOnOXEyxffQY/mwb2teeCs=; b=BkDvLW7nAAL4GOlIYSYdl2x/5Qq28C/sTVEIPMBw26Rrbkvpt/Xb7lX5rpYZbODXBV aU94PH/Fu+cXV91D+Kiz0xT7RXFt5FXn4tVycuXCbyFArNvqP7lahl9DsDXz1cK3ZcFX QuOdnku7vWl4kAaGpxoclI8+BkG12hoyJfQfaEue9veJs+YiJ6nZYXG1I9runEiURDQM F47nnsIZqtvAt/xagjHNybWagPhUaz9tzKrsJTS+TNXk2ZsfZZ8nZo2Bpo2NCJvuN10d ILvdGoJ5MKTbeGGDDk2524IBboHEnvMkQQcAQr6fstWwN7km1oz5JGfce2AOXRYp7YIi 9tJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/qWVDCASGrupwV9JyWG9rVOnOXEyxffQY/mwb2teeCs=; b=PMzE/BluBGMLr37rrA4wy0owNkQn3TSEZ6Tko8ZZPI3cBbPY3geOyKhWaXIvWuTGYP 6yDDkJYni9Dg+h0P3xsJ6bwSHAUWt7zt33hR1YQl8o5lkFoFYCJ1JtuMVwprPjZp8Gxa N+i8L24X8ofLj85QzPL2ucOopsA60/EsA6c1KLopbu7D6caaFqdUCbI47nUfdaA+pBL1 8+uLc6nkar9+MKU2StnETo9o115tRSlWg3hssY09zA9oLoDrlvnRaK9/qpxbFNa7UWHs F3tdILedIuB3f5Q+aGjoI4g/DvcZlz2alOnkMveZYIIj1dzmKuuH7jhSVEKbf5569Kb5 t9Ng== X-Gm-Message-State: AOAM533VI9JN4mpVlGokn5TbkrzpG9NjZCc9iTSgzyD0xowzwbsljope YQFsEkgRGy/CHz4OnGNYY8YeFw== X-Google-Smtp-Source: ABdhPJxBKiKJdxNtWNtq+f2bA/z02TwJEliskpuCyFZRXsHFO/Z9F1FHqBPOVxb6uI6t341ojQlFGA== X-Received: by 2002:a05:6830:144f:: with SMTP id w15mr10880048otp.62.1600139836899; Mon, 14 Sep 2020 20:17:16 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id l23sm4525960otk.79.2020.09.14.20.17.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2020 20:17:16 -0700 (PDT) Date: Mon, 14 Sep 2020 22:17:14 -0500 From: Bjorn Andersson To: Liu Shixin Cc: Niklas Cassel , Andy Gross , Kevin Hilman , Nishanth Menon , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] power: avs: qcom-cpr: simplify the return expression of cpr_disable() Message-ID: <20200915031714.GA670377@yoga> References: <20200915032629.1772569-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915032629.1772569-1-liushixin2@huawei.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon 14 Sep 22:26 CDT 2020, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin Reviewed-by: Bjorn Andersson > --- > drivers/power/avs/qcom-cpr.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c > index bd7c3e48b386..b24cc77d1889 100644 > --- a/drivers/power/avs/qcom-cpr.c > +++ b/drivers/power/avs/qcom-cpr.c > @@ -665,8 +665,6 @@ static int cpr_enable(struct cpr_drv *drv) > > static int cpr_disable(struct cpr_drv *drv) > { > - int ret; > - > mutex_lock(&drv->lock); > > if (cpr_is_allowed(drv)) { > @@ -676,11 +674,7 @@ static int cpr_disable(struct cpr_drv *drv) > > mutex_unlock(&drv->lock); > > - ret = regulator_disable(drv->vdd_apc); > - if (ret) > - return ret; > - > - return 0; > + return regulator_disable(drv->vdd_apc); > } > > static int cpr_config(struct cpr_drv *drv) > -- > 2.25.1 >