From: Colin King <colin.king@canonical.com>
To: Sebastian Reichel <sre@kernel.org>, Dan Murphy <dmurphy@ti.com>,
linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH][next] power: supply: bq25980: remove redundant zero check on ret
Date: Tue, 6 Oct 2020 18:06:00 +0100 [thread overview]
Message-ID: <20201006170600.545361-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
Currently ret is assigned to zero and the following statement checks
if it is non-zero. This check is redundant and can be removed
Addresses-Coverity: ("Logically dead code")
Fixes: 5069185fc18e ("power: supply: bq25980: Add support for the BQ259xx family")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/power/supply/bq25980_charger.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/power/supply/bq25980_charger.c b/drivers/power/supply/bq25980_charger.c
index 3995fb7cf060..f04f9acdb13b 100644
--- a/drivers/power/supply/bq25980_charger.c
+++ b/drivers/power/supply/bq25980_charger.c
@@ -613,9 +613,6 @@ static int bq25980_set_battery_property(struct power_supply *psy,
struct bq25980_device *bq = power_supply_get_drvdata(psy);
int ret = 0;
- if (ret)
- return ret;
-
switch (psp) {
case POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT:
ret = bq25980_set_const_charge_curr(bq, val->intval);
--
2.27.0
next reply other threads:[~2020-10-06 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 17:06 Colin King [this message]
2020-10-06 17:23 ` [PATCH][next] power: supply: bq25980: remove redundant zero check on ret Dan Murphy
2020-10-08 21:35 ` Sebastian Reichel
2020-10-06 17:52 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006170600.545361-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=dmurphy@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox